Skip to content

Commit

Permalink
chore: Remove Python 3.7 from workflows (#806)
Browse files Browse the repository at this point in the history
* chore: Remove Python 3.7 from workflows

* Skip batch send tests
  • Loading branch information
lahirumaramba authored Aug 28, 2024
1 parent 0d498a6 commit b4700da
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', 'pypy3.8']
python: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy3.8']

steps:
- uses: actions/checkout@v4
Expand All @@ -35,10 +35,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python 3.7
- name: Set up Python 3.8
uses: actions/setup-python@v5
with:
python-version: 3.7
python-version: 3.8
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.7
python-version: 3.8

- name: Install dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.7
python-version: 3.8

- name: Install dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ information on using pull requests.

### Initial Setup

You need Python 3.7+ to build and test the code in this repo.
You need Python 3.8+ to build and test the code in this repo.

We recommend using [pip](https://pypi.python.org/pypi/pip) for installing the necessary tools and
project dependencies. Most recent versions of Python ship with pip. If your development environment
Expand Down
2 changes: 2 additions & 0 deletions integration/test_messaging.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ def test_send_each_for_multicast():
assert response.exception is not None
assert response.message_id is None

@pytest.mark.skip(reason="Replaced with test_send_each")
def test_send_all():
messages = [
messaging.Message(
Expand Down Expand Up @@ -179,6 +180,7 @@ def test_send_all():
assert isinstance(response.exception, exceptions.InvalidArgumentError)
assert response.message_id is None

@pytest.mark.skip(reason="Replaced with test_send_each_500")
def test_send_all_500():
messages = []
for msg_number in range(500):
Expand Down

0 comments on commit b4700da

Please sign in to comment.