Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Auth: Update user details and custom claims in the same request #1876

Open
brettwillis opened this issue Aug 18, 2022 · 2 comments · May be fixed by #1882
Open

[FR] Auth: Update user details and custom claims in the same request #1876

brettwillis opened this issue Aug 18, 2022 · 2 comments · May be fixed by #1882
Assignees
@prameshj
Labels
api: auth type: feature request

Comments

@brettwillis
Copy link

brettwillis commented Aug 18, 2022 •
edited
Loading

Currently, the custome user claims can be updated with setCustomUserClaims(), and the user details can be updated with updateUser().

Both use same /accounts:update REST API under the hood.

Is there a particular reason why the updateUser() method does not allow updating the custom claims even though it is possible in the underlying REST API? A follow up point is: if the updateUser() method has this functionalitly, then the setCustomUserClaims() would become obsolete (just a convenience wrapper).

I'd like to be able to include a customClaims field in the UpdateRequest interface, so that, if needed, we can update the user's details and claims in a single request. Currently we need two separate network requests to do this.

Let me know, and I can help with a PR if you want.
@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@brettwillis
Copy link
Author

Side question: There seems to be a very low request rate quota on this /accounts:update API. I can't find it explicitly stated but it feels like 10 req/second, as per the account delete rate quota. Can you confirm what the quota is for this API?

This only makes it more important to be able to combine requests.

@brettwillis brettwillis linked a pull request Aug 22, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prameshj prameshj

Labels
api: auth type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support updating custom claims in updateUser() brettwillis/firebase-admin-node
4 participants
@lahirumaramba @brettwillis @google-oss-bot @prameshj