Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't display results with zero cosine (default=True) #19

Open
quillcraftsman opened this issue Sep 8, 2023 · 3 comments
Open

Don't display results with zero cosine (default=True) #19

quillcraftsman opened this issue Sep 8, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Prepare repositor...

Comments

@quillcraftsman
Copy link
Member

Now we have count parameter in find_similar. It's display results count. I propose to add another parameter display_zero_results (may be better name exists).

  • If this parameter is True then we will display all results
  • If this parameter is False then we will not display results with cos = 0.0
@quillcraftsman quillcraftsman added enhancement New feature or request good first issue Good for newcomers labels Sep 8, 2023
@hemen1
Copy link

hemen1 commented Sep 9, 2023

Hi
Can I work on this?

@hemen1
Copy link

hemen1 commented Sep 9, 2023

I suggest exclude_zero_cosine for the parameter name.

@quillcraftsman
Copy link
Member Author

@hemen1 , you are welcome. Please check this https://github.com/findsimilar/find-similar/blob/main/DEVELOPER_GUIDELINES.md for easy start with coding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Prepare repository to Open Source usind
Development

No branches or pull requests
2 participants
@hemen1 @quillcraftsman