Skip to content
This repository has been archived by the owner on Jan 18, 2020. It is now read-only.

breaking changes in 0.14 #382

Open
ubnt-intrepid opened this issue Dec 30, 2018 · 0 comments
Open

breaking changes in 0.14 #382

ubnt-intrepid opened this issue Dec 30, 2018 · 0 comments
Labels
breaking change requires major version bump

Comments

@ubnt-intrepid
Copy link
Contributor

ubnt-intrepid commented Dec 30, 2018

  • remove the server and test implementation from the core crate
  • remove a lifetime parameter from Endpoint (Remove lifetime parameter from Endpoint #383)
    • we should wait for the implementation of generic associated types (GAT) to be completed.
  • Add a type parameter to Endpoint to generalize the type of request bodies:
    trait Endpoint<Bd> {
        fn apply(&self, cx: ApplyContext<'_, Bd>) -> ApplyResult<Self::Future>;
    }
  • Introduce a trait that represents a Future with the explicit request information:
    trait Future<Bd> {
        type Ok;
        type Error;
    
        fn poll_ready(&mut self, cx: &mut FutureContext<'_, Bd>) -> Poll<Self::Ok, Self::Error>;
    }
@ubnt-intrepid ubnt-intrepid added the breaking change requires major version bump label Dec 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change requires major version bump
Projects
None yet
Development

No branches or pull requests

1 participant