-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop HHVM and PHP5.x support #504
Comments
I agree. |
I have fixed Travis builds (now passing). This would technically make us bump a major version, so unless you show big improvements, I’d rather not. |
Only if we bump PHP to 7/7.1 |
What do you mean “bump”? |
I mean dropping the supports for PHP 5 totally |
Thanks for the explanation. Yep, fully agree. |
Your welcome :) |
@denis-sokolov please add a milestone, so we dont miss this when we will create a new major version. |
Don't know if this issue is still open (last comment is 2 years old) but AFAIK the common consensus is that updating the version of dependencies is not a BC break. It's more like ending support for this specific dependency as no public interface changes. |
There is this discussion semver/semver#148 (comment) |
Isn't HHVM a runtime for Hack language? I don't believe dropping its support will be a good idea. For PHP version it's a must to stop supporting PHP 5.* |
For trivia there are no longer any supported HHVM versions that support PHP code, the last one was 3.30 supported until November 2019. They went entirely Hack since, so there is nothing to support anymore. |
Doesn't mean people aren't using it. PHP 5 is dead too... |
and 7.0 and 7.1 |
Some legacy projects that are unable to upgrade are taking advantage of this tool. Great work! |
Nothing stoping those projects using an old version of this, if we were to drop it. |
HHVM is used nearly anywhere and since php7 is a thing also doesnt has a real use-case anymore.
it was a great project to boost zend-php though.
we should drop hhvm and php5.x support and cleanup the code-base from hhvm workarounds (and drop hhvm ci).
do you guys agree? If so, I can provide a PR.
The text was updated successfully, but these errors were encountered: