Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate Rust Registry Support #27

Open
Devlyn-Nelson opened this issue Jul 17, 2024 · 3 comments
Open

Alternate Rust Registry Support #27

Devlyn-Nelson opened this issue Jul 17, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Devlyn-Nelson
Copy link

Currently when a dependency in a Cargo.toml uses a alternative rust registry it will show the crates.io version information, which doesn't apply to the situation. This is a just a mild annoyance also existing in the crates extension.

As an example I have a real dependency, bondrewd, that exists on both my-work-registry and crates.io. my-work-registry has a newer version that has not been fully reviewed/approved for public release. When I use my-work-registry like the example below: the out-of-date icon appears with the latest version available on crates.io.

[dependencies.bondrewd]
version = "0.2" ❌ 0.1.14
registry = "my-work-registry"
features = ["derive", "dyn_fns"]

Optimally dependi would detect the versions available on the registry rather that the crates.io version, or when a registry is detected simply disable the warnings for that dependency to avoid confusion.

Honestly this is not a big deal, but after migrating to dependi from crates I thought i would at least bring it up.

@serayuzgur
Copy link
Contributor

@Devlyn-Nelson, thanks for reaching out. We will plan this since it is commonly requested. @MOzanGul, let's include this in our planning.

@MOzanGul MOzanGul added the enhancement New feature or request label Jul 23, 2024
@MOzanGul MOzanGul added this to the 0.7.6 milestone Jul 23, 2024
@MOzanGul
Copy link

Hi @Devlyn-Nelson , we have fixed this issue per your request.
We'd be really happy if you could review Dependi, here is our reviews page.

@Devlyn-Nelson
Copy link
Author

So either I am doing something wrong, our registry isn't setup as to your specifications, or this should have never been closed.

I waited a while before posting because this had been closed faster than I could confirm if it worked or not. But now weeks later, I have tried too many things for this to be fixed. I even removed Windows in favor of Linux on my laptop with no luck from a fresh install. I am pretty confident saying it doesn't work correctly, and the details below are consistent for 3 Linux machines and a Windows machine. I have done clean builds, cargo updates, cargo cache (the cli app, and removing the files manually), and the clean install, etc...

In a project we have called radio-lib we use 8 other crates from our custom registry, 4 of which having names that conflict with crates.io. please also note that only 1 alternative registry is being used, so differing behaviour would be weird...

Screenshot_20240822_164201

3 of those crates show correct information.

  • threading has an identical version history so I can't really confirm its getting the version from the right place.
  • graphql is not on crates.io, but in other projects i see 0.1.0 as the latest version (see lower screenshot).
  • logging which is on crate.io with version 0.1.0. But, again, other projects show incorrect version information. Only the radio-lib project show correct information here.

3 don't show any version indicators at all, and none of them are on crates.io. In some projects it shows up as 3 red exclamation marks (see lower screen shot).

2 (config and protocol) are incorrect and use the crates.io latest version.

Again I want to say I have been trying to get this to work every weekday sense this issue was closed. All my machines show the same results per projects, but different projects can behave differently as well. Every single other project we have using logging in shows the crates.io version instead of the pumpkin-patch vesrion, radio-lib is the only project that shows logging correctly. the screen shot above provided the best result of all our projects with a 38% success rate.

Screenshot_20240822_171131

BUT it does work better than before you closed the issue, so that is a plus.

@MOzanGul MOzanGul reopened this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants