Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: semver-compatible updates marked with X #109

Open
djc opened this issue Aug 19, 2024 · 11 comments
Open

Regression: semver-compatible updates marked with X #109

djc opened this issue Aug 19, 2024 · 11 comments
Milestone

Comments

@djc
Copy link

djc commented Aug 19, 2024

Describe the bug

For Rust dependencies I'm now seeing that available semver-compatible updates yield an upgradable decoration when only semver-compatible updates are available. This was not the case previously, and is undesirable at least for me (not sure if this is some new configuration).

Screenshots

Screenshot 2024-08-19 at 14 26 00

I want to see only green checkboxes here, even if my Cargo.lock file is committed.

Desktop (please complete the following information):

  • OS: macOS
  • Version: 0.7.8
@MOzanGul
Copy link

Hi @djc, this is because of the latest update regarding support of .lock files. You can disable that feature in the Extension settings.
Let us know if that works for you.

@djc
Copy link
Author

djc commented Aug 19, 2024

It fills this immediate need but then causes problems with #51.

@serayuzgur
Copy link
Contributor

Hi @djc ,
Does this solves you issue ? Please test the attachment for test build. If works we will publish with new version.
PR

vscode-extension.zip

@djc
Copy link
Author

djc commented Aug 26, 2024

Do you have guidance on how to install an extension from .zip?

@MOzanGul
Copy link

MOzanGul commented Aug 26, 2024

Hi @djc ,
Firstly, unzip the folder.
Then you need to uninstall the extension if there is an installed version.
After that, you can install the .vsix file following the instructions on the screenshot below.
image

@djc
Copy link
Author

djc commented Aug 27, 2024

Honestly not sure if I can reliably reproduce this issue even with the marketplace version of the extension.

@MOzanGul
Copy link

Hi @djc ,
What do you suggest on how we we will go forward? We would like to know if you have any improvement ideas.

@djc
Copy link
Author

djc commented Sep 2, 2024

I feel like I've clearly indicated the experience that seems optimal for my use cases (basically the way the crates extension used to work), and I would like your team to own the work to ensure and test that your extension implements that behavior. That is:

  • I would prefer not to see an X for crates that only have semver-compatible updates, only for crates that have semver-incompatible updates
  • I would prefer not to see an alarm light for crates where the required version (in Cargo.toml) is vulnerable but the locked version (in Cargo.lock) is not vulnerable

To me, as such the current configuration of where I have to specifically have to opt in to considering the lockfile seems too low-level -- it doesn't operate at the conceptual level which I think is necessary.

@MOzanGul MOzanGul added this to the 0.7.10 milestone Sep 6, 2024
@masterflitzer
Copy link

what do you mean by semver-compatible updates (major/minor/patch)? i mean 0.7.2 is more up to date than 0.7.1 so the X is expected or am i missing something?

@djc
Copy link
Author

djc commented Sep 11, 2024

In Cargo, 0.7.2 is semver-compatible with 0.7.1 and 1.10.3 is semver-compatible with 1.7.1. With Cargo, cargo update will let me painlessly update all semver-compatible updates, while I have to do manual work for upgrading across semver-incompatible boundaries (like 0.7 -> 0.8 or 1.13 -> 2.0).

@masterflitzer
Copy link

thanks for the explanation, i've always used crates/dependi as indication for when to update, not matter how the boundary is, the current behavior is pretty useful when you don't regularly run cargo update, i'd definitely like it if both ways would be supported e.g. through configuration (idc which is the default behavior)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants