-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decorator for matching regular expressions #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks a lot. It is a feature that should have been implemented long ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the comments in the my previous review, sorry.
It would be nice to be able to access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the fixes, if you don't mind, I have a few more minor comments. Regarding the re.Match
objects, I agree, I don't think there is a neat way to return them and pattern matching is quite fast, so I'm inclined to leave as it is for now.
Cool! I think I've addressed all the review-- let me know if any other changes to be made, thanks again for taking a look at my changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy with the last set of changes, thanks!
Introduces a decorator similar to
@triggered
--named@regex_triggered
--which returns a command if any of the provided regular expression patterns match the message text