Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit dynamic manifest sender and update messages to ideally avoid nil manifests compeltely #502

Open
masih opened this issue Jul 23, 2024 · 0 comments

Comments

@masih
Copy link
Member

masih commented Jul 23, 2024

Now that there is a dedicated flag for pausing F3 participation via manifest the value of manifest itself should never be nil. But in code it is technically possible to propagate a nil manifest.

Refactor code such that:

  • it remains resilient against nil manifest, i.e. fails gracefully.
  • API disallows propagation of nil manifest, i.e. fails early.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants