Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split this plugin #648

Closed
WaKeMaTTa opened this issue Sep 20, 2017 · 1 comment
Closed

Split this plugin #648

WaKeMaTTa opened this issue Sep 20, 2017 · 1 comment
Labels
question Help requests and general enquiries from users. wontfix Requested changes that a maintainer has chosen not to fix, or is outright impossible to do.

Comments

@WaKeMaTTa
Copy link

WaKeMaTTa commented Sep 20, 2017

Hello,

Can plugin is 🆒 but this metrics is not 🆒 :

image

Can we split this plugin in to many plugins.

Example:

  • file-icons the minimum / the base
  • file-icons-office (requires file-icons-base) this have icons like: pdf, doc, docx, odt, txt, ...
  • file-icon-web (requires file-icons-base) this have icons of web: javascript, html, css,
  • file-icon-dinamic-css (requires file-icons-base) this have icons of web: sass, scss, less, ...
  • ...
@Alhadis
Copy link
Member

Alhadis commented Sep 21, 2017

Hi @WaKeMaTTa,

The number of icons and formats actually has very little impact on loading time. The slow activation time is the fault of certain implementation decisions that were made to overcome shortcomings in Atom's APIs.

Splitting file-icons into separate icon-related packages simply isn't going to happen. It would be messy and difficult to maintain, and would probably also require some ugly refactoring of the codebase. Furthermore, any improvement to startup time would be negligible at best, and slower at worst (due to the time it takes to load multiple packages, should users have many installed).

Consult and subscribe to #565 for details and updates about the slow loading time.

@Alhadis Alhadis closed this as completed Sep 21, 2017
@Alhadis Alhadis added the question Help requests and general enquiries from users. label Sep 21, 2017
@Alhadis Alhadis added the wontfix Requested changes that a maintainer has chosen not to fix, or is outright impossible to do. label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Help requests and general enquiries from users. wontfix Requested changes that a maintainer has chosen not to fix, or is outright impossible to do.
Projects
None yet
Development

No branches or pull requests

2 participants