From 2f542e7b0a44555caeac91fdf936918902bf1efe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Borja=20Jim=C3=A9nez?= <truestylegs@gmail.com> Date: Wed, 15 Jan 2025 01:12:59 +0100 Subject: [PATCH 1/2] fix configure using description --- packages/tables/src/Table.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/tables/src/Table.php b/packages/tables/src/Table.php index 38a5fd00a80..783fc186351 100644 --- a/packages/tables/src/Table.php +++ b/packages/tables/src/Table.php @@ -85,9 +85,15 @@ protected function setUp(): void { parent::setUp(); - $this->emptyStateDescription(function (Table $table): ?string { + $configuredDescription = $this->getEmptyStateDescription() ?? null; + + $this->emptyStateDescription(function (Table $table) use ($configuredDescription): ?string { if (! $table->hasAction('create')) { - return null; + return $configuredDescription ?? null; + } + + if ($configuredDescription) { + return $configuredDescription; } return __('filament-tables::table.empty.description', [ From bb8ac18375175121f8a1a3ff55494997c98d1aa9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Borja=20Jim=C3=A9nez?= <truestylegs@gmail.com> Date: Wed, 15 Jan 2025 01:35:42 +0100 Subject: [PATCH 2/2] change variable name --- packages/tables/src/Table.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/tables/src/Table.php b/packages/tables/src/Table.php index 783fc186351..f04001ce4f3 100644 --- a/packages/tables/src/Table.php +++ b/packages/tables/src/Table.php @@ -85,15 +85,15 @@ protected function setUp(): void { parent::setUp(); - $configuredDescription = $this->getEmptyStateDescription() ?? null; + $emptyStateDescription = $this->getEmptyStateDescription() ?? null; - $this->emptyStateDescription(function (Table $table) use ($configuredDescription): ?string { + $this->emptyStateDescription(function (Table $table) use ($emptyStateDescription): ?string { if (! $table->hasAction('create')) { - return $configuredDescription ?? null; + return $emptyStateDescription ?? null; } - if ($configuredDescription) { - return $configuredDescription; + if ($emptyStateDescription) { + return $emptyStateDescription; } return __('filament-tables::table.empty.description', [