Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme switcher tooltips stay on screen on mobile #8701

Open
binaryfire opened this issue Sep 24, 2023 · 6 comments
Open

Theme switcher tooltips stay on screen on mobile #8701

binaryfire opened this issue Sep 24, 2023 · 6 comments

Comments

@binaryfire
Copy link
Contributor

binaryfire commented Sep 24, 2023

Package

filament/filament

Package Version

3.0.60

Laravel Version

10.2.6

Livewire Version

No response

PHP Version

8.2

Problem description

The tooltips for the dark / light mode switcher stay on screen on mobile.

Expected behavior

They shouldn’t stay on screen after the switcher has closed.

Steps to reproduce

Visit https://demo.filamentphp.com/ on a mobile device. I’m using an iPhone X.

Reproduction repository

https://github.com/filamentphp/demo

Relevant log output

No response

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
@valpuia
Copy link
Contributor

valpuia commented Sep 25, 2023

I am using OnePlus (android 13) and I can't reproduce this

@binaryfire
Copy link
Contributor Author

binaryfire commented Sep 25, 2023

Screenshots from the demo site. iPhone X, happens in both Chrome and Safari:

IMG_0280
IMG_0279

@zepfietje
Copy link
Member

Can confirm this on iOS.
Have you found a fix, @binaryfire?

@zepfietje zepfietje added this to the v3 milestone Sep 25, 2023
@binaryfire
Copy link
Contributor Author

Hey @zepfietje. Couldn't figure it out. It could be related to tippy.js or Popper (which tippy uses under the hood). Development on both libraries has been discontinued and there are lots of open issues.

I'd really recommend switching Filament over to Floating UI if you're able. It's basically Popper v2.

@zepfietje
Copy link
Member

We're currently using https://github.com/ryangjchandler/alpine-tooltip, so let's ask @ryangjchandler about his opinion.

@zepfietje zepfietje changed the title Dark / light mode switcher tooltips stay on screen on mobile Theme switcher tooltips stay on screen on mobile Sep 26, 2023
@danharrin danharrin added bug in dependency help wanted and removed bug Something isn't working labels Dec 6, 2023
@polar-sh polar-sh bot added the Fund label Jun 3, 2024
@danharrin danharrin removed the fund label Jun 4, 2024
@zepfietje
Copy link
Member

Replaced by #13333.

@zepfietje zepfietje closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Jun 20, 2024
@danharrin danharrin reopened this Jun 24, 2024
@github-project-automation github-project-automation bot moved this from Done to Todo in Roadmap Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants