Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid table border on hover/select in dark mode #7784

Open
ajnsn opened this issue Aug 15, 2023 · 0 comments
Open

Grid table border on hover/select in dark mode #7784

ajnsn opened this issue Aug 15, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@ajnsn
Copy link
Contributor

ajnsn commented Aug 15, 2023

Package

filament/tables

Package Version

v3.0.19

Laravel Version

v10.18.0

Livewire Version

v3.0.0-beta.7

PHP Version

PHP 8.2

Problem description

Just a follow up. PR #7636 introduced a slight difference between classic tables and grid tables hover/select appearance in dark mode.

Grid tables before that PR look like classic tables

before

After that PR the borders are not highlighted on hover/select

after

Expected behavior

Both "tables" should look the same.

Steps to reproduce

  • Install Filament v3.0.18
  • Create a table with and without Grid Layout (e.g. Stack/Split columns)
  • Upgrade to Filament v3.0.19 (which includes the mentioned PR).

Reproduction repository

https://github.com/ajnsn/filament-demo-borders

Relevant log output

No response

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

3 participants