Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plain/transparent button variant #10558

Open
zepfietje opened this issue Dec 29, 2023 · 3 comments
Open

Add plain/transparent button variant #10558

zepfietje opened this issue Dec 29, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request low priority ui
Milestone

Comments

@zepfietje
Copy link
Member

zepfietje commented Dec 29, 2023

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
@zepfietje zepfietje added enhancement New feature or request ui labels Dec 29, 2023
@zepfietje zepfietje added this to the v4 milestone Dec 29, 2023
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Dec 29, 2023
@zepfietje zepfietje self-assigned this Dec 29, 2023
@polar-sh polar-sh bot added the Fund label Jun 3, 2024
@danharrin danharrin removed the fund label Jun 4, 2024
@danharrin
Copy link
Member

I think I'm going to close this one as I'm not entirely sure the use cases that would be covered that aren't already covered by other button variants in our design system.

@danharrin danharrin closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Jan 30, 2025
@zepfietje
Copy link
Member Author

It replaces the icon button as passing just an icon to a plain button looks identical.

The plain button mainly serves as a way to have an action without attracting too much visual attention, e.g. the cancel button in modal dialogs.

@zepfietje zepfietje reopened this Feb 10, 2025
@github-project-automation github-project-automation bot moved this from Done to Todo in Roadmap Feb 10, 2025
@danharrin danharrin modified the milestones: v4.0.0-alpha1, v4 Feb 10, 2025
@danharrin
Copy link
Member

Why would you use a plain button over a gray button for Cancel in a modal for example? I just fail to see the value here when we already have an icon button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority ui
Projects
Status: Todo
Development

No branches or pull requests

2 participants