Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract core styles to plugin or stylesheet #10437

Open
14 of 16 tasks
zepfietje opened this issue Dec 22, 2023 · 8 comments
Open
14 of 16 tasks

Extract core styles to plugin or stylesheet #10437

zepfietje opened this issue Dec 22, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@zepfietje
Copy link
Member

zepfietje commented Dec 22, 2023

Initial pass to remove Tailwind classes from views into CSS files with @apply (CSS files could be restructured, moved, or imported differently to how they are now, the work in this stage is just to create the files)

  • actions
  • forms
  • infolists
  • notifications
  • panels
  • schema
  • spark-billing-provider
  • spatie-laravel-google-fonts-plugin
  • spatie-laravel-media-library-plugin
  • spatie-laravel-settings-plugin
  • spatie-laravel-tags-plugin
  • spatie-laravel-translatable-plugin
  • support
  • tables
  • upgrade
  • widgets

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
@zepfietje zepfietje added the enhancement New feature or request label Dec 22, 2023
@zepfietje zepfietje added this to the v4 milestone Dec 22, 2023
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Dec 22, 2023
@zepfietje
Copy link
Member Author

@danharrin you can document your experiment findings here if you like.

@zepfietje
Copy link
Member Author

CSS layers will make theming much easier already: https://developer.mozilla.org/en-US/docs/Web/CSS/@layer.

@polar-sh polar-sh bot added the Fund label Jun 3, 2024
@danharrin danharrin removed the fund label Jun 4, 2024
@pxlrbt
Copy link
Member

pxlrbt commented Jul 9, 2024

Just wanted to throw in, that we should consider introducing more CSS vars for everything like colors to make stuff more customisable.

@zepfietje
Copy link
Member Author

Could you clarify what you mean specifically, @pxlrbt?

@pxlrbt
Copy link
Member

pxlrbt commented Jul 12, 2024

What I mean is, that it would be good if it's possible to extract some often used configs to CSS vars, to allow easier customization. Colors would probably be the easiest. Other parts may be trickier. Also determining what might be useful could be tricky 😅

--sidebar-background
--sidebar-color
--border-radius

@zepfietje
Copy link
Member Author

Naming design tokens is definitely tricky. Especially when keeping extensibility in mind.

@zepfietje
Copy link
Member Author

Just wanted to mention this doesn't solve the table performance issue: #9304 (comment).

@khalilKhassep

This comment has been minimized.

@danharrin danharrin moved this from Todo to In Progress in Roadmap Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

4 participants