From 5ecfcad137e135a2212a05d5c8daae49124499da Mon Sep 17 00:00:00 2001
From: Carsten Bach <mail@carsten-bach.de>
Date: Tue, 27 Feb 2024 23:55:18 +0100
Subject: [PATCH] WIP fix CS issues

---
 inc/impressum/namespace.php           |  95 +++++++-----
 inc/namespace.php                     |   4 +-
 inc/preferred-languages/namespace.php |  78 +++++-----
 inc/sites/installation.php            | 200 ++++++++++----------------
 inc/sites/registration.php            |  40 +++---
 inc/users/namespace.php               |  20 +--
 inc/wp-approve-user/namespace.php     |  30 ++--
 phpstan.neon                          |   1 +
 8 files changed, 226 insertions(+), 242 deletions(-)

diff --git a/inc/impressum/namespace.php b/inc/impressum/namespace.php
index 0b2da68..0f77196 100644
--- a/inc/impressum/namespace.php
+++ b/inc/impressum/namespace.php
@@ -32,8 +32,12 @@ function bootstrap(): void {
 	add_action( 'plugins_loaded', __NAMESPACE__ . '\\load_plugin', 4 );
 }
 
-
-function load_plugin() {
+/**
+ * Load the plugin itself and its modifications.
+ *
+ * @return void
+ */
+function load_plugin(): void {
 
 	require_once FT_VENDOR_DIR . PLUGINPATH; // phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingCustomConstant
 
@@ -43,41 +47,56 @@ function load_plugin() {
 		return;
 	}
 
-	add_action( 'impressum_country_after_sort', __NAMESPACE__ . '\\impressum_country_after_sort' );
-	add_action( 'impressum_legal_entity_after_sort', __NAMESPACE__ . '\\impressum_legal_entity_after_sort' );
+	add_filter( 'impressum_country_after_sort', __NAMESPACE__ . '\\impressum_country_after_sort' );
+	add_filter( 'impressum_legal_entity_after_sort', __NAMESPACE__ . '\\impressum_legal_entity_after_sort' );
 
 	add_action( 'admin_head-settings_page_impressum', __NAMESPACE__ . '\\cleanup_admin_ui' );
 }
 
 
-function filter_options() {
+/**
+ * Handle options
+ *
+ * @return void
+ */
+function filter_options(): void {
 	
 	$_options = [
 		'dismissed-impressum_welcome_notice' => true,
-		// OPTION => [] // DO NOT HANDLE, as it's the user-data
+		// OPTION => [] // DO NOT HANDLE, as it's the user-data!
 	];
 
-	// gets added to the 'OptionsCollection' 
-	// from within itself on creation
-		new Options\Factory( 
-			$_options, 
-			'Figuren_Theater\Options\Option', 
-			BASENAME, 
-		);
+	// Gets added to the 'OptionsCollection' 
+	// from within itself on creation.
+	new Options\Factory( 
+		$_options, 
+		'Figuren_Theater\Options\Option', 
+		BASENAME, 
+	);
 }
 
 
-// set Impressum-location, ft_geo-catgeories and WP_LANG
-// in one go, by just .... updating an option
-// 
-function pre_update_ft_geo_option_from_imprint( mixed $new_value, mixed $old_value, string $option_name ): mixed {
+/**
+ * Set Impressum-location, ft_geo-catgeories and WP_LANG in one go, by just .... updating an option.
+ * 
+ * Filters a specific option before its value is (maybe) serialized and updated.
+ *
+ * The dynamic portion of the hook name, `$option`, refers to the option name.
+ *
+ * @see https://developer.wordpress.org/reference/hooks/pre_update_option_option/
+ *
+ * @param  array<string, string> $new_value    The new, unserialized option value.
+ * @param  array<string, string> $old_value    The old option value.
+ * @param  string                $option_name  Name of the option in the DB.
+ *
+ * @return array<string, string>               The new, updated option value ready for being saved to the database.
+ */
+function pre_update_ft_geo_option_from_imprint( array $new_value, array $old_value, string $option_name ): array {
 
-	// do nothing,
-	// if nothing (on the address) has changed
-	// $new_value['country'] could be unset by Figuren_Theater\Onboarding\Sites\Installation\set_imprint_page()
-	// so check it
+	// Do nothing, if nothing (on the address) has changed.
+	// Do check '$new_value['country']', which could be unset by Figuren_Theater\Onboarding\Sites\Installation\set_imprint_page().
 	if ( isset( $new_value['country'] ) && 
-		// can be bool, if non existent yet
+		// Can be bool, if non existent yet.
 		isset( $old_value['country'] ) && 
 		$old_value['country'] === $new_value['country']
 		&&
@@ -86,21 +105,20 @@ function pre_update_ft_geo_option_from_imprint( mixed $new_value, mixed $old_val
 		return $new_value;
 	}
 
-	// otherwise
-	// start the geo-engines :)
+	// Start the geo-engines :) !
 	$ft_geo_options_bridge = new Geo\ft_geo_options_bridge();
 	$ft_geo                = $ft_geo_options_bridge->update_option_ft_geo( $old_value, $new_value, $option_name );
 
-	// set adress to verified version
+	// Set adress to verified version.
 	if ( isset( $ft_geo['address'] ) && ! empty( $ft_geo['address'] ) ) {
 		$new_value['address'] = $ft_geo['address'];
 	} else {
-		// or reset
+		// Or reset.
 		$new_value['address'] = $old_value['address'];
 	} 
-	// set country to verified version
+	// Set country to verified version.
 	if ( isset( $ft_geo['geojson']['properties']['address']['country'] ) ) {
-		// crazy country codes by 'Impressum' plugin
+		// Crazy country codes by 'Impressum' plugin.
 		$_country_helper      = [
 			'de' => 'deu',
 			'at' => 'aut',
@@ -108,19 +126,23 @@ function pre_update_ft_geo_option_from_imprint( mixed $new_value, mixed $old_val
 		];
 		$new_value['country'] = $_country_helper[ $ft_geo['geojson']['properties']['address']['country_code'] ];
 	} else {
-		// or reset
+		// Or reset.
 		$new_value['country'] = $old_value['country'];
 	}
 
-	// go on and save
+	// Go on and save.
 	return $new_value;
 }
 
 
 /**
+ * Reduce countries to relevant ones.
+ * 
  * Filter the countries after localized alphabetical sorting.
  * 
- * @param    array $countries The current countries
+ * @param  array<string, string> $countries The current countries.
+ * 
+ * @return array<string, string> $countries The filtered countries.
  */
 function impressum_country_after_sort( array $countries ): array {
 	return [
@@ -132,9 +154,13 @@ function impressum_country_after_sort( array $countries ): array {
 
 
 /**
+ * Reduce legal entities to relevant ones.
+ * 
  * Filter the legal entities after localized alphabetical sorting.
  * 
- * @param    array $countries The current countries
+ * @param  array<string, string> $legal_entities The current legal entities.
+ * 
+ * @return array<string, string>                 The filtered legal entities.
  */
 function impressum_legal_entity_after_sort( array $legal_entities ): array {
 	return [
@@ -144,6 +170,11 @@ function impressum_legal_entity_after_sort( array $legal_entities ): array {
 }
 
 
+/**
+ * Reduce up-sell bloat & clutter from admin settings-page.
+ *
+ * @return void
+ */
 function cleanup_admin_ui(): void {
 	echo '<style>
 		.settings_page_impressum .nav-tab-wrapper,
diff --git a/inc/namespace.php b/inc/namespace.php
index 0a4be31..7e0aee6 100644
--- a/inc/namespace.php
+++ b/inc/namespace.php
@@ -12,8 +12,10 @@
 
 /**
  * Register module.
+ *
+ * @return void
  */
-function register() {
+function register(): void {
 
 	$default_settings = [
 		'enabled'                   => true, // Needs to be set.
diff --git a/inc/preferred-languages/namespace.php b/inc/preferred-languages/namespace.php
index 447a93a..ad2bfee 100644
--- a/inc/preferred-languages/namespace.php
+++ b/inc/preferred-languages/namespace.php
@@ -8,11 +8,8 @@
 namespace Figuren_Theater\Onboarding\Preferred_Languages;
 
 use Figuren_Theater\Onboarding\Impressum;
-
 use FT_VENDOR_DIR;
-
-use Figuren_Theater; // FT
-
+use Figuren_Theater;
 use function add_action;
 use function update_option;
 
@@ -29,6 +26,7 @@ function bootstrap(): void {
 	add_action( 'plugins_loaded', __NAMESPACE__ . '\\load_plugin', 4 );
 }
 
+
 /**
  * Conditionally load the plugin itself and its modifications.
  *
@@ -39,10 +37,8 @@ function load_plugin(): void {
 	require_once FT_VENDOR_DIR . PLUGINPATH; // phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingCustomConstant
 
 	// Fires after the value of 'impressum_imprint_options' has been successfully updated.
-	// 
-	// update_option_ is not triggered reliably
-	// so switch to pre_update_option_
-	add_action( 'pre_update_option_' . Impressum\OPTION, __NAMESPACE__ . '\\set_pref_lang_from_impressum', 100, 2 );
+	// Because 'update_option_' is not triggered reliably, so switch to 'pre_update_option_'.
+	add_filter( 'pre_update_option_' . Impressum\OPTION, __NAMESPACE__ . '\\set_pref_lang_from_impressum', 100, 2 );
 }
 
 
@@ -50,36 +46,34 @@ function load_plugin(): void {
  * 'ft_geo' was successfully changed, 
  * so lets change 'WPLANG' accordingly.
  * 
- * Fires after the value of a specific option has been successfully updated.
+ * Filters a specific option before its value is (maybe) serialized and updated.
  *
  * The dynamic portion of the hook name, `$option`, refers to the option name.
  *
- * @since 2.0.1
- * @since 4.4.0 The `$option` parameter was added.
+ * @see https://developer.wordpress.org/reference/hooks/pre_update_option_option/
  *
- * @param mixed  $old_o The old option value.
- * @param mixed  $o     The new option value.
- * @param string $option    Option name.
+ * @param  array<string, string> $new_value The new option value.
+ * @param  array<string, string> $old_value The old option value.
+ * 
+ * @return array<string, string>
  */
-// function set_pref_lang_from_impressum( $old_o, $o ) {
-function set_pref_lang_from_impressum( $o, $old_o ): array {
-
-	// do nothing,
-	// if nothing (on the address) has changed
-	// $o['country'] could be unset by Figuren_Theater\Onboarding\Sites\Installation\set_imprint_page()
-	// so check it
-	if ( isset( $o['country'] ) && 
-		// can be bool, if non existent yet
-		isset( $old_o['country'] ) && 
-		$old_o['country'] === $o['country'] &&
-		$old_o['address'] === $o['address']
+function set_pref_lang_from_impressum( array $new_value, array $old_value ): array {
+
+	// Do nothing, if nothing (on the address) has changed.
+	// $o['country'] could be unset by Figuren_Theater\Onboarding\Sites\Installation\set_imprint_page(),
+	// so check it.
+	if ( isset( $new_value['country'] ) && 
+		// Can be bool, if non existent yet.
+		isset( $old_value['country'] ) && 
+		$old_value['country'] === $new_value['country'] &&
+		$old_value['address'] === $new_value['address']
 	) {
-		return $o;
+		return $new_value;
 	}
 
-	// change order of default translations, 
-	// based on sites' country
-	switch ( $o['country'] ) {
+	// Change order of default translations, 
+	// based on sites' country.
+	switch ( $new_value['country'] ) {
 
 		case 'che':
 			$_informal_defaults = [
@@ -91,8 +85,8 @@ function set_pref_lang_from_impressum( $o, $old_o ): array {
 			$_formal_defaults   = [
 				'de_CH',
 				'de_DE_formal',
-				'de_CH_informal', // fallback, better than default en_US
-				'de_DE', // fallback, better than default en_US
+				'de_CH_informal', // Fallback, better than default en_US.
+				'de_DE', // Fallback, better than default en_US.
 			];
 			break;
 
@@ -106,15 +100,15 @@ function set_pref_lang_from_impressum( $o, $old_o ): array {
 			$_formal_defaults   = [
 				'de_DE_formal',
 				'de_CH',
-				'de_AT', // fallback, better than default en_US
-				'de_DE', // fallback, better than default en_US
+				'de_AT', // Fallback, better than default en_US.
+				'de_DE', // Fallback, better than default en_US.
 			];
 			break;
 
 		case 'deu':
 		default:
-			// this is the informal-default
-			// the typical use-case for theater-people
+			// This is the informal-default,
+			// the typical use-case for theater-people.
 			$_informal_defaults = [
 				'de_DE',
 				'de_CH_informal',
@@ -125,21 +119,21 @@ function set_pref_lang_from_impressum( $o, $old_o ): array {
 			$_formal_defaults = [
 				'de_DE_formal',
 				'de_CH',
-				'de_DE', // fallback, better than default en_US
+				'de_DE', // Fallback, better than default en_US.
 			];
 			break;
 	}
 
-	// get current ft_site
+	// Get current 'ft_site'.
 	$ft_site    = Figuren_Theater\FT::site();
 	$use_formal = (bool) $ft_site->has_feature( [ 'in-foermlicher-sprache' ] );
 
-	// switch formal and informal translations, based on choosen feature
+	// Switch formal and informal translations, based on choosen feature.
 	$_defaults = ( $use_formal ) ? $_formal_defaults : $_informal_defaults;
 
-		update_option( 'preferred_languages', join( ',', $_defaults ), 'yes' );
+	update_option( 'preferred_languages', join( ',', $_defaults ), 'yes' );
 
-		update_option( 'WPLANG', $_defaults[0], 'yes' );
+	update_option( 'WPLANG', $_defaults[0], 'yes' );
 
-		return $o;
+	return $new_value;
 }
diff --git a/inc/sites/installation.php b/inc/sites/installation.php
index 1e0da3c..2b4d6f8 100644
--- a/inc/sites/installation.php
+++ b/inc/sites/installation.php
@@ -7,29 +7,29 @@
 
 namespace Figuren_Theater\Onboarding\Sites\Installation;
 
+use Figuren_Theater; 
 use Figuren_Theater\FeaturesRepo;
-use FT_CORESITES;
-use Figuren_Theater; // FT, FT_Query
-
 use Figuren_Theater\inc;
-
 use Figuren_Theater\Network\Post_Types;
 use Figuren_Theater\Network\Sync;
 use Figuren_Theater\Network\Users;
-
+use FT_CORESITES;
 use WP_Site;
-
 use function add_action;
 use function apply_filters;
+use function check_admin_referer;
 use function do_action;
 use function esc_html;
 use function get_blog_option;
 use function get_bloginfo;
+use function get_current_blog_id;
+use function get_userdata;
 use function is_wp_error;
+use function restore_current_blog;
+use function switch_to_blog;
 use function update_option;
 use function wp_insert_post;
 
-
 /**
  * Bootstrap module, when enabled.
  *
@@ -39,9 +39,7 @@ function bootstrap(): void {
 
 	/**
 	 * Fires once a site has been inserted into the database.
-	 */
-	// 'wp_insert_site' => 'insert_first_content', // kept to remind
-	/**
+	 * 
 	 * The hook wpmu_new_blog gives you a deprecated notice 
 	 * and tells you to use wp_insert_site. 
 	 * 
@@ -54,9 +52,15 @@ function bootstrap(): void {
 }
 
 
-function load( WP_Site $new_site, $args ): void {
-
-
+/**
+ * Fires when a site’s initialization routine should be executed.
+ *
+ * @param  WP_Site                   $new_site New site object.
+ * @param  array<string, int|string> $args     Arguments for the initialization.
+ *
+ * @return void
+ */
+function load( WP_Site $new_site, array $args ): void {
 
 	add_action( 
 		__NAMESPACE__ . '\\insert_first_content', 
@@ -64,13 +68,15 @@ function load( WP_Site $new_site, $args ): void {
 		0, 
 		2
 	);
-	/*
+	
+	/* phpcs:ignore 
 	add_action( 
 		__NAMESPACE__ . '\\insert_first_content', 
 		__NAMESPACE__ . '\\set_home_page',
 		5, 
 		2
-	);*/
+	);
+	*/
 
 	add_action( 
 		__NAMESPACE__ . '\\insert_first_content', 
@@ -85,11 +91,11 @@ function load( WP_Site $new_site, $args ): void {
 		5
 	);
 	
-	// taken from \wp-includes\ms-site.php
+	// Taken from \wp-includes\ms-site.php.
 	$switch = false;
 	if ( get_current_blog_id() !== $new_site->id ) {
 		$switch = true;
-		switch_to_blog( $new_site->id );
+		switch_to_blog( $new_site->id ); // phpcs:ignore WordPressVIPMinimum.Functions.RestrictedFunctions.switch_to_blog_switch_to_blog
 	}
 
 		do_action( 
@@ -109,13 +115,15 @@ function load( WP_Site $new_site, $args ): void {
  *
  * @see https://github.com/WordPress/WordPress/blob/master/wp-includes/ms-site.php#L105 
  *
- * @since 5.1.0
- *
- * @param WP_Site $new_site New site object.
- * @param array   $args     Arguments for the initialization.
+ * @param  WP_Site                   $new_site New site object.
+ * @param  array<string, int|string> $args     Arguments for the initialization.
+ * 
+ * @return void
  */
-function create_new__ft_site( WP_Site $new_site, $args ) {
- 
+function create_new__ft_site( WP_Site $new_site, array $args ): void {
+	// Defined at wp-admin/network/site-new.php.
+	check_admin_referer( 'add-blog', '_wpnonce_add-blog' );
+
 	if ( isset( $_POST['ft_level'] ) && 0 < intval( $_POST['ft_level'] ) ) {
 		$args['ft_level'] = (int) $_POST['ft_level'];
 	}
@@ -142,36 +150,29 @@ function create_new__ft_site( WP_Site $new_site, $args ) {
 
 	// 5. add 'ft_bot' user to new website
 	// by calling 'him' short circuited
-	$_temp_ft_bot = Users\ft_bot::id();
+	Users\ft_bot::id();
 }
 
 
 /**
  * Fired once a site has been inserted into the database.
+ *
+ * @param  WP_Site                   $new_site New site object.
+ * @param  array<string, int|string> $args     Arguments for the initialization.
+ * 
+ * @return void
  */
-function set_home_page( WP_Site $new_site, $args ) {
-	// do we have a home in place ?
-	// $home_page_id = (int) \get_option( 'page_on_front' );
-
-	// if the home-page already exists 
-	// JUMP OUT
-	// if ( $home_page_id && inc\helper::post_id_exists( $home_page_id ) ) {
-		// return;
-	// }
-
-	// if the home-page not exists , go on
-	// and create one ...
-
-	// get the user, who registered the site
-	// or fallback to the bot user, if some error occured
+function set_home_page( WP_Site $new_site, array $args ) {
+	
+	// Get the user, who registered the site
+	// or fallback to the bot user, if some error occured.
 	$post_author = ( isset( $args['user_id'] ) && 0 < $args['user_id'] ) ? $args['user_id'] : Users\ft_bot::id();
 
 	$new_home_page = [
 
 		'post_author'    => $post_author,
 
-		'post_title'     => __( 'Front page' ),
-		// 'post_name'      => __('Front page'),
+		'post_title'     => __( 'Front page', 'default' ),
 
 		'post_type'      => 'page',
 		'post_status'    => 'publish',
@@ -179,9 +180,6 @@ function set_home_page( WP_Site $new_site, $args ) {
 
 		'comment_status' => 'closed',
 		'ping_status'    => 'closed',
-
-		// 'meta_input'     => [
-		// ],
 	];
 	
 	// Get initial content for the front-page,
@@ -197,40 +195,27 @@ function set_home_page( WP_Site $new_site, $args ) {
 		$new_home_page['post_content'] = $_ft_frontpage_content;
 	}
 
-	// and save it to the db
+	// Save it to the DB.
 	$home_page_id = wp_insert_post( $new_home_page, true );
 
 	if ( ! is_wp_error( $home_page_id ) ) {
-				update_option( 'page_on_front', (int) $home_page_id, 'yes' );
-	} else {
-				do_action( 'qm/error', $home_page_id );
+		update_option( 'page_on_front', (int) $home_page_id, 'yes' );
 	}
 }
 
 
-
-
 /**
  * Fired once a site has been inserted into the database.
  * 
- * @param WP_Site $new_site New site object.
- * @param array   $args     Arguments for the initialization.
+ * @param  WP_Site                   $new_site New site object.
+ * @param  array<string, int|string> $args     Arguments for the initialization.
+ * 
+ * @return void
  */
-function set_imprint_page( WP_Site $new_site, $args ) {
-	// do we have a imprint in place ?
-	// $impressum_imprint_options = \get_option( 'impressum_imprint_options' );
+function set_imprint_page( WP_Site $new_site, array $args ): void {
 
-	// $imprint_page_id = ( isset($impressum_imprint_options['page']) ) ? (int) $impressum_imprint_options['page'] : false;
-
-	// if the imprint-page already exists 
-	// JUMP OUT
-	// if ( $imprint_page_id && inc\helper::post_id_exists( $imprint_page_id ) ) {
-		// return;
-	// }
-
-	// if the imprint-page not exists , go on
-	// and get the ID of the 'main' imprint-page from the network_blog
-	// this is the one to pull
+	// Get the ID of the 'main' imprint-page from the network_blog,
+	// this is the one to pull.
 	$ft_coresites_ids                 = array_flip( FT_CORESITES );
 	$remote_site_id                   = (int) $ft_coresites_ids['mein'];    
 	$remote_impressum_imprint_options = get_blog_option( 
@@ -240,39 +225,35 @@ function set_imprint_page( WP_Site $new_site, $args ) {
 	);
 	$remote_imprint_page_id           = ( isset( $remote_impressum_imprint_options['page'] ) ) ? (int) $remote_impressum_imprint_options['page'] : false;
 
-	// if we have nothing from remote 
-	// JUMP OUT
+	// If we have nothing from remote, JUMP OUT.
 	if ( ! $remote_imprint_page_id ) {
 		return;
 	}
 
-	// establish a connection 
-	// and define pulling
+	// Establish a connection and define pulling.
 	$distributor = new Sync\Pull( 
 		[ $remote_imprint_page_id ],
 		$remote_site_id,
 		'page'
 	);
-	// run pulling
+	// Run pulling.
 	$imprint_page_id = $distributor->run();
 
-	// return on failure or
-	// set our option if everything was fine
+	// Return on failure or set our option if everything was fine.
 	if ( empty( $imprint_page_id ) || ! inc\helper::post_id_exists( (int) $imprint_page_id[0] ) ) {
 		return;
 	}
 
-	// prepare some data,
-	// which was collected during registration
-	$person = \get_userdata( $args['user_id'] );
+	// Prepare some data, which was collected during registration.
+	$person = get_userdata( $args['user_id'] );
 
-	// get temporary data, collected during registration
+	// Get temporary data, collected during registration.
 	$user_registration_data = $person->get( FeaturesRepo\TEMP_USER_META );
 
 	$impressum_imprint_options = [
 		'page'                => (string) $imprint_page_id[0],
-		'country'             => '', // leave empty as it gets populated on save, if empty
-		'legal_entity'        => 'self', // self-employed
+		'country'             => '', // Leave empty as it gets populated on save, if empty.
+		'legal_entity'        => 'self', // Means 'self-employed' in the 'Impressum' plugin.
 		'name'                => $person->display_name,
 		'address'             => $user_registration_data['adr'],
 		'address_alternative' => '',
@@ -283,75 +264,48 @@ function set_imprint_page( WP_Site $new_site, $args ) {
 		'vat_id'              => '',
 	];
 
-	// unset new country
-	// to prevent automatic combinations of ADR + COUNTRY that dont fit
-	// possible, when 'impressum_imprint_options' is pre-populated during install 
-	// but was never really used within this blog
+	// Unset new country,
+	// to prevent automatic combinations of ADR + COUNTRY that dont fit.
+	// Maybe possible, when 'impressum_imprint_options' is pre-populated during install,
+	// but was never really used within this blog.
 	unset( $impressum_imprint_options['country'] );
 	update_option( 'impressum_imprint_options', $impressum_imprint_options, 'no' );
-
-	// ---
-
-	// now that we successfully updated the adr
-	// the blog has default terms of geolocation taxonomy available
-	// but we need to trigger an update on its ft_site
-	// to have the new geo-data distributed to all plattforms
-	// 
-	// that's a little bit weird,
-	// because normally this shouldn't be needed,
-	// as we have a 'update_option_default_{GEOTAX}_terms' action in place
-	// which SHOULD trigger an update of this 'ft_site' post
-	// but nothing ....
-	// 
-	// update_option( 'blogname', $_impressum_imprint_options['name'] );
-	// update_option( 'blogdescription', $_impressum_imprint_options['name'] );
 }
 
 
-
-
-
 /**
  * Fired once a site has been inserted into the database.
+ * 
+ * @return void
  */
-function set_privacy_page() {
-	// do we have a privacy-policy in place ?
-	// $policy_page_id = (int) \get_option( 'wp_page_for_privacy_policy' );
-
-	// if the privacy-policy-page already exists 
-	// JUMP OUT
-	// if ( $policy_page_id && inc\helper::post_id_exists( $policy_page_id ) ) {
-		// return;
-	// }
-
-	// if the privacy-policy-page not exists , go on
-	// and get the ID of the 'main' privacy-page from the network_blog
-	// this is the one to pull
-	$ft_coresites_ids = array_flip( FT_CORESITES );
-	// $remote_site_id = (int) $ft_coresites_ids['root'];
+function set_privacy_page(): void {
+
+	// Get the ID of the 'main' privacy-page from the network_blog,
+	// this is the one to pull.
+	$ft_coresites_ids      = array_flip( FT_CORESITES );
 	$remote_site_id        = (int) $ft_coresites_ids['mein']; 
 	$remote_policy_page_id = (int) get_blog_option( 
 		$remote_site_id,
 		'wp_page_for_privacy_policy',
 		false
 	);
-	// if we have nothing from remote 
-	// JUMP OUT
+
+	// If we have nothing from remote, JUMP OUT.
 	if ( ! $remote_policy_page_id ) {
 		return;
 	}
 
-	// establish a connection 
-	// and define pulling
+	// Establish a connection and define pulling.
 	$distributor = new Sync\Pull( 
 		[ $remote_policy_page_id ],
 		$remote_site_id,
 		'page'
 	);
-	// run pulling
+	
+	// Run pulling.
 	$policy_page_id = $distributor->run();
 
-	// .. and set our option if everything was fine
+	// Save our option if everything was fine.
 	if ( ! empty( $policy_page_id ) ) {
 		update_option( 'wp_page_for_privacy_policy', (int) $policy_page_id[0], 'no' );
 	}
diff --git a/inc/sites/registration.php b/inc/sites/registration.php
index 0184d26..a7cc366 100644
--- a/inc/sites/registration.php
+++ b/inc/sites/registration.php
@@ -77,28 +77,39 @@ function add_extra_field_on_blog_signup(): void {
 }
 
 
+/**
+ * Get a html-select with potential new levels for site-creation.
+ * 
+ * @todo https://github.com/figuren-theater/ft-onboarding/issues/18 Find nice way to get (one of many) sitemanagement-blogs.
+ *
+ * @return string
+ */
 function get_ft_level_select(): string {
-	// 1. switch to (a) sitemanagement-blog, which has the required 'ft_level'-data
-	// TODO #18 // find nice way to get (one of many) sitemanagement-blogs
+	// 1. Switch to (a) sitemanagement-blog, which has the required 'ft_level'-data.
 	$sitemanagement_blog = array_flip( FT_CORESITES )['webs'];
-	switch_to_blog( $sitemanagement_blog );
+	switch_to_blog( $sitemanagement_blog ); // phpcs:ignore WordPressVIPMinimum.Functions.RestrictedFunctions.switch_to_blog_switch_to_blog
 
-	// 4. get 'ft_level'-posts
+	// 4. Get all 'ft_level'-posts.
 	$ft_level_select = ft_level_select();
 
-	// 5. restore_current_blog();
+	// 5. Restore to current blog.
 	restore_current_blog();
 
 	return $ft_level_select;
 }
 
 
+/**
+ * Get potential new levels from current network-site aka network-root.
+ *
+ * @return string
+ */
 function ft_level_select(): string {
 
-	// not avail. via composer,
-	// so we have to require it usually
+	// Unfortunately not available via composer,
+	// so we have to require it manually.
 	if ( file_exists( Onboarding\DIRECTORY . '/inc/sites/wp_dropdown_posts/wp_dropdown_posts.php' ) ) {
-		require_once Onboarding\DIRECTORY . '/inc/sites/wp_dropdown_posts/wp_dropdown_posts.php';
+		require_once Onboarding\DIRECTORY . '/inc/sites/wp_dropdown_posts/wp_dropdown_posts.php'; // phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingCustomConstant
 	}
 
 	if ( ! function_exists( 'wp_dropdown_posts' ) ) {
@@ -106,8 +117,6 @@ function ft_level_select(): string {
 	}
 
 	$ft_level_dropdown_args = [
-		// 'selected'              => FALSE,
-		// 'pagination'            => FALSE,
 		'posts_per_page'        => 25,
 		'post_status'           => 'publish',
 		'cache_results'         => true,
@@ -115,19 +124,10 @@ function ft_level_select(): string {
 		'echo'                  => 0,
 		'select_name'           => Post_Types\Post_Type__ft_level::NAME,
 		'id'                    => Post_Types\Post_Type__ft_level::NAME,
-		// 'class'                 => '',
 		'show'                  => 'post_title',
-		// 'show_callback'         => NULL,
 		'show_option_all'       => 'Choose ft_level as receipe.',
-		// 'show_option_none'      => 'No ft_level avail. :(',
-		// 'option_none_value'     => '',
-		// 'multi'                 => FALSE,
-		// 'value_field'           => 'ID',
-		// 'order'                 => 'ASC',
-		// 'orderby'               => 'post_title',
-
 
-		// WP_Query arguments
+		// Typical WP_Query arguments.
 		'post_type'             => Post_Types\Post_Type__ft_level::NAME,
 		'no_found_rows'         => true, // Useful when pagination is not needed.
 	];
diff --git a/inc/users/namespace.php b/inc/users/namespace.php
index a01cfb0..0379117 100644
--- a/inc/users/namespace.php
+++ b/inc/users/namespace.php
@@ -26,7 +26,7 @@ function bootstrap(): void {
 /**
  * Load modifications to 'user_register' workflow.
  *
- * @param  int  $user_id The ID of the new user.
+ * @param  int $user_id The ID of the new user.
  *
  * @return void
  */
@@ -36,9 +36,9 @@ function load( int $user_id ): void {
 		'ID' => $user_id,
 	];
 
-	$args = __set_names( $args );
+	$args = set_names( $args );
 
-	$args = __set_admin_color( $args );
+	$args = set_admin_color( $args );
 
 	wp_update_user( $args );
 }
@@ -47,13 +47,13 @@ function load( int $user_id ): void {
 /**
  * Save defaults for 'display_name' and 'nickname' based on users first and last name.
  *
- * @param  array $args List of arguments to throw at 'wp_update_user()'.
+ * @param  array<string, int|string> $args List of arguments to throw at 'wp_update_user()'.
  *
- * @return array
+ * @return array<string, int|string>
  */
-function __set_names( array $args ): array {
+function set_names( array $args ): array {
 	
-	$user = get_userdata( $args['ID'] );
+	$user = get_userdata( (int) $args['ID'] );
 	
 	if ( empty( $user->first_name ) || empty( $user->last_name ) ) {
 		return $args;
@@ -70,11 +70,11 @@ function __set_names( array $args ): array {
 /**
  * Set default admin-color-scheme to 'figurentheater'.
  *
- * @param  array $args List of arguments to throw at 'wp_update_user()'.
+ * @param  array<string, int|string> $args List of arguments to throw at 'wp_update_user()'.
  *
- * @return array
+ * @return array<string, int|string> 
  */
-function __set_admin_color( array $args ): array {
+function set_admin_color( array $args ): array {
 	
 	$args['admin_color'] = Admin_UI\Color_Scheme::NAME;
 	
diff --git a/inc/wp-approve-user/namespace.php b/inc/wp-approve-user/namespace.php
index 78756e6..1be6b45 100644
--- a/inc/wp-approve-user/namespace.php
+++ b/inc/wp-approve-user/namespace.php
@@ -8,13 +8,9 @@
 namespace Figuren_Theater\Onboarding\WP_Approve_User;
 
 use FT_VENDOR_DIR;
-
 use Figuren_Theater;
 use Figuren_Theater\Options;
-use function Figuren_Theater\get_config;
-
 use Obenland_Wp_Approve_User;
-
 use function add_action;
 use function add_filter;
 use function remove_action;
@@ -31,10 +27,11 @@ function bootstrap(): void {
 
 	add_action( 'Figuren_Theater\loaded', __NAMESPACE__ . '\\filter_options', 11 );
 
-	// the plugin itself will init on 'plugins_loaded:0'
+	// The plugin itself will init on 'plugins_loaded:0'.
 	add_action( 'plugins_loaded', __NAMESPACE__ . '\\load_plugin', -1 );
 }
 
+
 /**
  * Conditionally load the plugin itself and its modifications.
  *
@@ -47,29 +44,34 @@ function load_plugin(): void {
 		return;
 	}
 
-	// needed to load the plugin
+	// Needed to load the plugin.
 	add_filter( 'pre_option_users_can_register', '__return_true' );
 
 	require_once FT_VENDOR_DIR . PLUGINPATH; // phpcs:ignore WordPressVIPMinimum.Files.IncludingFile.UsingCustomConstant
 
 
-	// the plugin itself will load on 'plugins_loaded:10'
+	// The plugin itself will load on 'plugins_loaded:10'.
 	add_action( 'plugins_loaded', __NAMESPACE__ . '\\unload_plugin_parts', 11 );
 }
 
 
-function unload_plugin_parts() {
-	// do check if wp-user-approve is loaded !!
+/**
+ * Remove network-admin menu.
+ *
+ * @return void
+ */
+function unload_plugin_parts(): void {
+	// Remove plugins menu.
 	$wpau = Obenland_Wp_Approve_User::get_instance();
-	if ( ! $wpau ) {
-		return;
-	}
-
-	// Remove plugins menu
 	remove_action( 'network_admin_menu', [ $wpau, 'admin_menu' ], 10 );
 }
 
 
+/**
+ * Handle options
+ *
+ * @return void
+ */
 function filter_options(): void {
 
 	$_options = [
diff --git a/phpstan.neon b/phpstan.neon
index 6c63bc8..a1562e0 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -20,3 +20,4 @@ parameters:
     ignoreErrors:
         # Find a nicer way instead of ignoring this Error on every ft-module
         - '#Function Altis\\register_module not found\.#'
+        - '#Function Figuren_Theater\\get_config not found\.#'