Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-day-picker #6

Open
bhogan-mitre opened this issue Feb 3, 2023 · 1 comment
Open

Update react-day-picker #6

bhogan-mitre opened this issue Feb 3, 2023 · 1 comment

Comments

@bhogan-mitre
Copy link
Contributor

There is a first attempt in the date-picker-update branch, and some discussion attached to a commit there 89fb41f

Let's consolidate that discussion into an issue here so that it's easier to find and refer to.

@bhogan-mitre
Copy link
Contributor Author

@dmt0 I understand the month navigation buttons are not currently working in that development branch. Here are a couple thoughts (copied over from the thread on that commit).

It looks like there is different behavior between providing month and defaultMonth. A quick try on my end to use defaultMonth did respond to changes in the <> buttons. Although the dropdown month and year controls above it weren't synced with those changes and would need additional tweaking. https://react-day-picker.js.org/api/interfaces/DayPickerBase#month

Maybe a better approach would be to remove those extra dropdowns above the DayPicker, and instead use dropdowns from within DayPicker (and in that way get rid of the <> buttons as well). That seems like it would better match the existing behavior. https://react-day-picker.js.org/basics/navigation#using-a-drop-down-to-change-the-month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant