Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_size parameter for polygonize step #72

Open
ando-shah opened this issue Dec 17, 2024 · 4 comments · May be fixed by #73
Open

max_size parameter for polygonize step #72

ando-shah opened this issue Dec 17, 2024 · 4 comments · May be fixed by #73

Comments

@ando-shah
Copy link

It would be useful to have a --max_size parameter (in sq. m) for theftw inference polygonize command.

Motivation: would make it easier to use out-of-the-box, as I see some truly gigantic polygons sometimes that are too big to be agricultural fields in smallholder settings.

@cholmes
Copy link
Member

cholmes commented Dec 17, 2024

Yeah, that's a great idea. Should be pretty easy to implement. If you have any desire to try out adding it you'd be more than welcome. I coded most of it with Cursor, so AI written contributions are welcome.

Any thoughts on what a good default max_size parameter should be?

m-mohr added a commit that referenced this issue Dec 18, 2024
m-mohr added a commit that referenced this issue Dec 18, 2024
m-mohr added a commit that referenced this issue Dec 18, 2024
@m-mohr m-mohr linked a pull request Dec 18, 2024 that will close this issue
@m-mohr m-mohr linked a pull request Dec 18, 2024 that will close this issue
@m-mohr
Copy link
Collaborator

m-mohr commented Dec 18, 2024

I've created a PR for it: #73

@ando-shah
Copy link
Author

As you know, this might depend on the particular agricultural regime in question. In my case, I'm filtering out anything beyond 10 ha., as this is the limit of smallholder farm sizes in north-western India.

@m-mohr
Copy link
Collaborator

m-mohr commented Dec 31, 2024

@ando-shah sure, please test the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants