Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #250 - Add boolean option for passphrase #343

Closed
isaacvr opened this issue Oct 31, 2019 · 0 comments
Closed

Fixes #250 - Add boolean option for passphrase #343

isaacvr opened this issue Oct 31, 2019 · 0 comments

Comments

@isaacvr
Copy link
Contributor

isaacvr commented Oct 31, 2019

Fixes #250

Changes:

  • Add with_passphrase option to fsm_getKeyPairAtIndex. This allows you to enable or not the use of a passphrase for mnemonic and, therefore, to use two generations of different addresses, as long as the device has the passphrase option enabled.
  • In other uses of this function (fsm_getKeyPairAtIndex) outside the signing process, the argument with_passphrase is passed as true, because before this change that was the behavior. Note that in the future the selection of passphrase or not, should be considered in the future in these cases.

Does this change need to mentioned in CHANGELOG.md?
yes

Requires testing
yes

Comments about testing , should you have some

@isaacvr isaacvr closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant