Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]define device type for update firmware USB by default ref #165 #166

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

[WIP]define device type for update firmware USB by default ref #165 #166

wants to merge 19 commits into from

Conversation

stdevAlDen
Copy link
Contributor

Fixes #165

Changes:

  • Change input reader signature to work with multiple parameters, this allow improve the user interaction

Does this change need to mentioned in CHANGELOG.md?
no

Requires changes in protobuff specs?
no

Requires testing
no

@stdevAlDen stdevAlDen added bug Something isn't working enhancement New feature or request labels Jan 14, 2020
@stdevAlDen stdevAlDen requested a review from olemis January 14, 2020 23:57
@stdevAlDen stdevAlDen self-assigned this Jan 14, 2020
Alvaro Denis added 11 commits January 14, 2020 19:02
give more details in the input reader to inprove user interaction ref f…
0c8ef9b 
…ibercrypto#165
be able to send cancel command as user interaction response ref fiber…
8923ce4 
…crypto#165
use different interaction alternatives from the scanner
3f2e8c1 
Ok, Cancel, Ok&Cancel ...

ref fibercrypto#165
handle word request scenario from the scanner ref fibercrypto#165
5c1f195
fix upload firmware to work with the sequencer schema ref fibercrypto…
1d8f120 
…#165
b able to set the emulator ip as argument ref fibercrypto#167
cc032be
update changes log ref fibercrypto#167
113a1be
Merge branch 'stdevAlDen_t167_emulator_ip_as_argument' into stdevAlDe…
0ef4186 
…n_t165_inprove_input_reader ref fibercrypto#165
fix typo in err ref fibercrypto#165
06acbc9
fix typo in err ref fibercrypto#165
b84b4ab
fix metho name in update firmware ref fibercrypto#165
4c0e96d
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t165_inprove_input_reader branch 4 times, most recently from 7cb174c to 6c685d0 Compare February 28, 2020 05:19
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t165_inprove_input_reader branch from 6c685d0 to 1502bc3 Compare February 28, 2020 05:19
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t165_inprove_input_reader branch from f062fd9 to bb55119 Compare March 3, 2020 23:16
use proper err response for emulator
46ffeb7 
use ErrNoDeviceConnected as response when not emulator is available
ref fibercrypto#165
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t165_inprove_input_reader branch from bb55119 to 46ffeb7 Compare March 3, 2020 23:17
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t165_inprove_input_reader branch from 80ae76a to 6484cf9 Compare March 3, 2020 23:42
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t165_inprove_input_reader branch 2 times, most recently from a8b30d1 to 315aa29 Compare March 4, 2020 01:06
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t165_inprove_input_reader branch from 315aa29 to 869e580 Compare March 4, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemis olemis Awaiting requested review from olemis

Assignees

@stdevAlDen stdevAlDen

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve input reader for the Sequencer Devicer implementation.
2 participants
@stdevAlDen @olemis