Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of Set instead of unique List #8

Open
fluktuid opened this issue May 30, 2022 · 1 comment
Open

Usage of Set instead of unique List #8

fluktuid opened this issue May 30, 2022 · 1 comment

Comments

@fluktuid
Copy link

In my eyes, the specification of the tags in docker-make.yaml is somewhat confusing.

The List of tags is defined as a list of unique values.
So i think it's more straight-forward if a Set is used.

builds:
- name: Latest Stable
  tags:
  ? 1
  ? 1.1
  ? 1.1.0
  ? 1.1.0-acme
@fluktuid fluktuid changed the title Usage of Lists instead of Sets Usage of Set instead of unique List May 30, 2022
@Gerrit91
Copy link
Collaborator

Hi there,

there is little movement on this repository. Changing the existing data structure results into a breaking API and I don't think the benefit of the suggested change is very beneficial. I am eager to accept pull request regarding security and bug fixes but I really want to avoid changing the existing API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fluktuid @Gerrit91