Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: OA.NormalizerZTrans loses internal normalization parameters #1111

Closed
3 tasks
detlefarend opened this issue Dec 5, 2024 · 1 comment · Fixed by #1102
Closed
3 tasks

Bug: OA.NormalizerZTrans loses internal normalization parameters #1111

detlefarend opened this issue Dec 5, 2024 · 1 comment · Fixed by #1102
Assignees
@detlefarend
Labels
enhancement New feature or request OA Online adaptivitiy

Comments

@detlefarend
Copy link
Member

1 Describe the bug
There are actually two problems with the normalizer:

2 To Reproduce
Steps to reproduce the behavior:

  1. Run ./test/howtos/oa/howto_oa_streams_pp_121_complex_preprocessing.py
  2. Observe plot window 'Stream Task 6 - Normalizer Z-Trans (ND)' (only 1 out of 3 features is visible)
  3. Debug the same howto
    • set breakpoint in method NormalizerZTrans._run(): the second call kills the normalization parameters for feature 2 and 3...

3 Expected behavior
Normalized values of all three features should be visible...

4 Screenshots
If applicable, add screenshots to help explain your problem.

5 Additional Informations

5.1 Operating System

  • Linux
  • Windows
  • Mac OS
@detlefarend detlefarend added bug Something isn't working admin Administrative task quality Quality assurance OA Online adaptivitiy labels Dec 5, 2024
@detlefarend detlefarend self-assigned this Dec 5, 2024
detlefarend added a commit that referenced this issue Dec 5, 2024
@detlefarend
Bug: OA.NormalizerZTrans loses internal normalization parameters #1111
e0f0ac3
@detlefarend detlefarend linked a pull request Dec 5, 2024 that will close this issue
Final changes in v2.0.0 (4) #1102
Merged
detlefarend added a commit that referenced this issue Dec 6, 2024
@detlefarend
Bug: OA.NormalizerZTrans loses internal normalization parameters #1111
5b0c39e
detlefarend added a commit that referenced this issue Dec 9, 2024
@detlefarend
Bug: OA.NormalizerZTrans loses internal normalization parameters #1111
b8b8688
@detlefarend detlefarend added enhancement New feature or request and removed bug Something isn't working admin Administrative task quality Quality assurance labels Dec 9, 2024
@detlefarend
Copy link
Member Author

Solved! It was actually NOT a problem with class NormalizerZTrans but with the howto mentioned. However, the class NormalizerZTrans has been reviewed and optimized regarding performance.

The type and title of this issue were changed afterward.

detlefarend added a commit that referenced this issue Dec 9, 2024
@detlefarend
Bug: OA.NormalizerZTrans loses internal normalization parameters #1111
15266b9
@detlefarend detlefarend reopened this Dec 9, 2024
detlefarend added a commit that referenced this issue Dec 9, 2024
@detlefarend
Bug: OA.NormalizerZTrans loses internal normalization parameters #1111
4123883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@detlefarend detlefarend

Labels
enhancement New feature or request OA Online adaptivitiy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Final changes in v2.0.0 (4) fhswf/MLPro
1 participant
@detlefarend