Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip recompression doesn't work when archive is not compressed #54

Open
andrews05 opened this issue Dec 3, 2017 · 3 comments
Open

Zip recompression doesn't work when archive is not compressed #54

andrews05 opened this issue Dec 3, 2017 · 3 comments

Comments

@andrews05
Copy link
Contributor

For zip archives that have been created using level 0 ("store"), ect does not recompress the files inside.

@andrews05
Copy link
Contributor Author

andrews05 commented Dec 3, 2017

Found this is deliberate by Leanify, though not sure why.
For the record, advzip happily compresses these files.

@fhanau
Copy link
Owner

fhanau commented Dec 3, 2017

https://github.com/fhanau/Efficient-Compression-Tool/blob/master/src/leanify/zip.cpp#L330
According to source code, this may break files. Even though I did not verify this claim, I don't think it's worth risking it.

@fhanau
Copy link
Owner

fhanau commented Jun 9, 2018

Ok, according to JayXon/Leanify#42 this seems to be fine in most cases, so I will at least port these changes to add an option to compress uncompressed files within a zip file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants