Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add unicode support #139

Open
UpscaleAnon opened this issue Apr 27, 2024 · 3 comments
Open

Please add unicode support #139

UpscaleAnon opened this issue Apr 27, 2024 · 3 comments

Comments

@UpscaleAnon
Copy link

Come on already, it's been a major issue since 2016... You expect people to rename every file they have that for example has japanese characters?

@xBZZZZ
Copy link

xBZZZZ commented Apr 27, 2024

ect -zip 🥜

created valid 🥜.zip for me (linux x86-64)

@UpscaleAnon
Copy link
Author

ect -zip 🥜

created valid 🥜.zip for me (linux x86-64)

Doesn't work on Windows 10.

G:\ECT>ect -5 "G:\ECT\80750022_p0 - イラストリアス.jpg"
No compatible files found

G:\ECT>ect -5 "G:\ECT\🥜.jpg"
No compatible files found

@fhanau
Copy link
Owner

fhanau commented Apr 28, 2024

Hi, ECT is not under active development so I will not be adding new features like Unicode support for the foreseeable future unfortunately. As a German speaker, this also affects me with [äöüẞ] characters not being usable (this is of course a larger issue with other languages). Adding support for Unicode characters would not be trivial as ECT includes several libraries that perform file I/O. identifying all such cases and implementing a unified approach for I/O that supports all file formats, then fixing any bugs in edge cases would be a larger effort.
I think xBZZZZ is saying that zip file creation appears to work with him. If that's the case that is great although I can't guarantee that this applies in all cases, especially since zip file creation for one file and for several files uses different code paths IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants