Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain a naming convention for release artifacts. #112

Open
nathanielcwm opened this issue Oct 24, 2022 · 1 comment
Open

Maintain a naming convention for release artifacts. #112

nathanielcwm opened this issue Oct 24, 2022 · 1 comment

Comments

@nathanielcwm
Copy link

nathanielcwm commented Oct 24, 2022

I'm making this issue because the recent change in the release binaries name with 0.9.3 and 0.9.2 broke the autoupdate script in ScoopInstaller/Main. I've mitigated this issue temporarily with ScoopInstaller/Main#4054 but it would be nice if this wouldn't be an issue in the future.

I'm interested in making a Github Actions job to automatically create builds for releases.

@fhanau
Copy link
Owner

fhanau commented Oct 24, 2022

Hello Nathaniel, I think that's a good suggestion. I recently started using GitHub actions in a different project so I'm familiar with using it. For building on Windows, I generally use MinGW or cross-compile from Unix, while there have been contributions to fix MSVC build issues I have not tried it myself.
With the releases, I usually also take some steps like stripping the build and having ECT compress itself to get a smaller size of the binary and gzipped binary, but those are less important.
Give me some time to review the changes, I also plan to follow semantic versioning in the future to avoid issues with binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants