Add support for Artifactory 7 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official artifactory package contains all required files.
Binaries should not be included in this module, but instead downloaded when required.
Recent versions of artifactory use a bundled java, so there is no need to mess with the system java anymore.
Some logic was duplicated in epp templates. Also do not re-validate class parameters in epp templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Artifactory version 7 came some breaking changes. This PR addresses these changes and applies some small refactorings to v6 support (because it touches the same code).
Overview of the changes in this PR:
$manage_java, Artifactory now uses a bundled version of Java (closes Why does the module install java 8? #7)config.ppThe
config.ppdiff looks huge, but this is mostly due to space changes. :)I suggest to release this as part of module version 3.0.0 because it includes breaking changes.