Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version variable for download URLs #21

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

kate-goldenring
Copy link
Collaborator

Simplifies updating a formula to only be resetting hashes. May prevent nitty errors in the future

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice! Didn't know this was possible. LGTM.

@kate-goldenring
Copy link
Collaborator Author

kate-goldenring commented Nov 13, 2023

Looks like brew test-bot is somehow not realizing this is a tap anymore and is trying to install the homebrew core spin project: https://github.com/fermyon/homebrew-tap/actions/runs/6854772721/job/18638412540#step:8:90

Previously didn't happen: https://github.com/fermyon/homebrew-tap/actions/runs/6828962688/job/18574160348#step:8:36

This is a known issue that has a pending fix in brew: Homebrew/brew#16216

We may consider not pointing at brew master or we can wait for that to merge

@vdice
Copy link
Member

vdice commented Nov 13, 2023

Looks like the upstream issue is already merged. Do we need to wait for a release -- or just retrigger the action?

@kate-goldenring kate-goldenring merged commit 90208f9 into fermyon:main Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants