Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow children with groups are not visible in bullboard #770

Open
apizzini opened this issue Jun 9, 2024 · 6 comments
Open

flow children with groups are not visible in bullboard #770

apizzini opened this issue Jun 9, 2024 · 6 comments

Comments

@apizzini
Copy link

apizzini commented Jun 9, 2024

When using flows and groups (which is a bullmq pro feature), flow children jobs are not visible.

For example adding a flow like this (without children.*.opts.group):

      await this.searchBulkFlowProducer.add({
        name: "renovate-interior",
        queueName: "search-bulk",
        children: [
          { name: "paint", queueName: "search-bulk" },
          { name: "paint", queueName: "search-bulk" },
          { name: "fix", queueName: "search-bulk" },
        ],
      });

results in:
Screenshot 2024-06-09 alle 17 28 30

But adding a flow with children.*.opts.group like this:

      await this.searchBulkFlowProducer.add({
        name: "renovate-interior",
        queueName: "search-bulk",
        children: [
          { name: "paint", queueName: "search-bulk" },
          { name: "paint", queueName: "search-bulk" },
          { name: "fix", queueName: "search-bulk" },
        ].map((item) => ({
          ...item,
          opts: {
            group: { id: "group1" },
          },
        })),
      });

results in this

Screenshot 2024-06-09 alle 17 30 43

Bullmq processes all jobs, flow children are simply not visible in bullboard.

Are pro features out of context in bullboard or is there interest to have that handled?

I'll be more than happy to open a PR to fix this if bullboard intend to support this feature :)

@judsd
Copy link

judsd commented Jun 17, 2024

Hello,

I ran into the same issue earlier. In our case, we are not using FlowProducer but just groups along with priority.

group: {
    id: campaignId,
    priority: priority
}

I can confirm the issue remains even if the priority is removed.

I didn't dig deeper, but I assume since the library is using the standard bullmq library, those jobs are not returned by the library.

I think a PR would be great if you already have a fix; otherwise, I can take a look at it by the end of the week.

On a side note, I checked the official UI at taskforce.sh, and it appears they have the same limitation at this time. the data is presented under groups.

Cheers,
Jud

@Matanya7491
Copy link

So, how i can support groups in bull-borad?
just with priority?

@felixmosh
Copy link
Owner

How can I get the bullmq-pro?
what is this groups feature?

@Matanya7491
Copy link

It's an important feature to understand how to view the division in Bull-Board according to the groups in Bull-Pro.
https://docs.bullmq.io/bullmq-pro/groups.

Taskforce using a free token or are interested in using Taskforce on a trial basis.
https://taskforce.sh/

Need to log in and get a token for npm registry
https://docs.taskforce.sh/bullmq-pro

We can see the division according to the groups in Redis Insight.
image

This is helpful for us, and we would like to know how to support this feature in Bull-Board as well?

Thanks for the answer and for the great library!

@felixmosh
Copy link
Owner

Yeah, it seems that "groups" were implemented by adding the group name into the name of the queue.
I'm not sure how (if at all) bull-board supports bullmq-pro lib, I've not tested it at all.

If you have time, I'll more than happy to review a PR for this.

@Matanya7491
Copy link

I'll try to see how I can support it and will update you.
Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants