Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package cln 1.3.7 feelpp/spack#2 #46162

Merged
merged 3 commits into from
Sep 2, 2024
Merged

package cln 1.3.7 feelpp/spack#2 #46162

merged 3 commits into from
Sep 2, 2024

Conversation

prudhomm
Copy link
Contributor

@prudhomm prudhomm commented Sep 2, 2024

@spackbot-app spackbot-app
Copy link

spackbot-app bot commented Sep 2, 2024

Hi @prudhomm! I noticed that the following package(s) don't yet have maintainers:

  • cln

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("prudhomm")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame cln

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

wdconinc
wdconinc approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for signing on as maintainer! 🎉

Commit verified.

FYI: no reason to change the URL, even for packages that aren't pulling from git commits. Spack deduces the correct URL even from older version URLs.

@wdconinc wdconinc merged commit e5aa74e into spack:develop Sep 2, 2024
13 checks passed
@prudhomm prudhomm deleted the 2-package-cln-137 branch September 2, 2024 03:50
mvlopri pushed a commit to mvlopri/spack that referenced this pull request Sep 4, 2024
@prudhomm @mvlopri
package cln 1.3.7 feelpp#2 (spack#46162)
8aebde8 
* package cln 1.3.7 feelpp#2

* add myself as maintainer

* fix style issue, rm blankline
@greenc-FNAL greenc-FNAL mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdconinc wdconinc wdconinc approved these changes

Assignees
No one assigned
Labels
new-version update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package cln 1.3.7 update cln package to 1.3.7
2 participants
@prudhomm @wdconinc