generated from feelpp/feelpp-project
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
215 make memory a parameter #218
Open
JavierCladellas
wants to merge
102
commits into
master
Choose a base branch
from
215-make-memory-a-parameter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,312
−499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
[ci skip]
[ci skip]
(Finally)
(sets nodes = tasks if no tasks_per_node specified...rfm bug?)
JavierCladellas
added
enhancement
A new feature or request
hpc
High-performance computing related
benchmarking
Issues related to benchmarking
labels
Jan 22, 2025
✅ Deploy Preview for benchmarking-polite-crostata-92f389 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ent parameter names but same value)
Add benchmark for feelpp_toolbox_heat - ThermalBridgesENISO10211
…d job result (status) ( This will change upon report lib refactoring )
(this should be calculated by the scheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
benchmarking
Issues related to benchmarking
enhancement
A new feature or request
hpc
High-performance computing related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
resources
field, containing tasks, nodes, exclusive_access and memory values. Conceived to be used along with parameters, like this:conditions
field to parameters, enabling to select given combinations (pruning) of the parameter space.For example,
Will only run the tests:
M1 with tasks 64, 128, 256 (default value "all" as not specified in conditions)
M2 only with 128 tasks
M3 with 128 and 256 tasks
Will not run any tests for M4
Also accepts multiple conditions for a given value, e.g
"M2":{ "tasks": [128], "discretization": ["P1","P3"] }
Removed the
memory
field of the root of the configuration file, it should now be specified under theresources
field. The--mem
directive is still added to the scheduler script[❗ IMPORTANT ❗ ] Removed the
use_nodes_option
. The--nodes
directive will no longer be emitted. But--ntasks
and--ntasks-per-node
will always appear, we should let the scheduler allocate the number of nodes it needs. ( Done like this because reframe does not let to specify the number of nodes, although we can explicitly pass the--nodes
directive but will be scheduler dependent). What do you think @vincentchabannesThe scheduler script is now exported on the ReFrame report, along with output and error logs. A link to these are now included in the report (adoc) parameter table.
Separated resource handling
resources.py
using strategy+factory pattern to handle tasks-nodes-tasks_per_node-memory combinations.Also updated tests.
The actual value of
num_nodes
,tasks
andtasks_per_node | None
should be shown in the report, not only the parameter values (as they might differ, be updated )Scripts and logs should be exported even on failed tests (if the job fails during the run phase, logs will not be exported 😢 )