Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When bond4 negotiation is not complete, the ifup script arping fails and the error information is misleading. #465

Open
lbo874 opened this issue Dec 4, 2023 · 2 comments

Comments

@lbo874
Copy link

lbo874 commented Dec 4, 2023

I run the ifup script while the bond4 negotiation process is running and not finished. The arping command fails to be executed. The command output is as follows:
image

Obviously, the up failure is not caused by an IP address conflict. I think such an error is misleading.
image
https://github.com/fedora-sysv/initscripts/blob/32f0ddf2efb7e02227febca5c43acae36a52f569/network-scripts/ifup-eth#L296C11-L296C11
Whether this can be optimized. You can correct the up error information based on the arping command output, or try again in this case.

@lnykryn
Copy link
Member

lnykryn commented Dec 4, 2023

Yeah, that part of the code is .... suboptimal. It is already stupid that we call some random sed on the output (and yeah I know it was my code). In the ideal case, we should find out if arping returns different return codes on different events and base the behavior on that. But to be honest, initscripts are no longer actively developed and almost nobody is using the network part these days, so this is not a priority for us. But I would be happy to review any patch to improve this.

@lnykryn
Copy link
Member

lnykryn commented Dec 4, 2023

In your case, it might be enough to set ARPING_WAIT to some higher value in the ifcfg file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants