Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend tests for ModuleStream.depends_on_stream() to cover empty stream lists #192

Closed
sgallagher opened this issue Feb 15, 2019 · 4 comments
Closed

Extend tests for ModuleStream.depends_on_stream() to cover empty stream lists #192

sgallagher opened this issue Feb 15, 2019 · 4 comments
Labels
enhancement good first issue Easy tickets suitable for a new contributor

Comments

@sgallagher
Copy link
Collaborator

The tests for depends_on_stream() and build_depends_on_stream() should validate that it handles the case of an empty list of streams properly.

As per the specification, the behavior here must be that an empty list means "all possible values".
@sgallagher sgallagher added enhancement good first issue Easy tickets suitable for a new contributor labels Feb 15, 2019
@athira-selvam
Copy link
Contributor

Hi,
I am an Outreachy applicant, I would like to work on this project. Shall work on this issue?

  • Thank you.

@sgallagher
Copy link
Collaborator Author

Please go right ahead!

I've also just added a new section to the README.md to help you get started setting up your development environment. Please let me know if you have any difficulty with getting started.

@athira-selvam
Copy link
Contributor

Hi,
I did set up the development environment. I need some help. Is modulestream.py - the file that I have to add the tests to? I found some tests for depends_on_stream() and build_depends_on_stream() in that file. Just wanted confirmation before I proceed.

@sgallagher
Copy link
Collaborator Author

Hi,
I did set up the development environment. I need some help. Is modulestream.py - the file that I have to add the tests to? I found some tests for depends_on_stream() and build_depends_on_stream() in that file. Just wanted confirmation before I proceed.

Yes, those are the tests I meant. You can choose to write them in either the Python tests or into new C tests in modulemd/v2/tests/test-modulemd-modulestream.c (related: #199)

athira-selvam added a commit to athira-selvam/libmodulemd that referenced this issue Feb 28, 2019
@athira-selvam
Extends tests for ModuleStream.depends_on_stream()
873dc5c 
The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists
Replicates the existing python tests, and newly added tests for depends_on_stream to C.
Fixes : fedora-modularity#192
related:  fedora-modularity#199
@athira-selvam athira-selvam mentioned this issue Feb 28, 2019
Closed
athira-selvam added a commit to athira-selvam/libmodulemd that referenced this issue Mar 6, 2019
@athira-selvam
Extends tests for ModuleStream.depends_on_stream()
e9b5fcd 
The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists

issue: fedora-modularity#192
@athira-selvam athira-selvam mentioned this issue Mar 6, 2019
Merged
athira-selvam added a commit to athira-selvam/libmodulemd that referenced this issue Mar 13, 2019
@athira-selvam
[WIP]Extends tests for ModuleStream.depends_on_stream()
7055387 
The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists

issue: fedora-modularity#192
athira-selvam added a commit to athira-selvam/libmodulemd that referenced this issue Mar 13, 2019
@athira-selvam
Extends tests for ModuleStream.depends_on_stream()
b466c8c 
The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists

issue: fedora-modularity#192
athira-selvam added a commit to athira-selvam/libmodulemd that referenced this issue Mar 14, 2019
@athira-selvam
Extends tests for ModuleStream.depends_on_stream()
d5a36cc 
The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists

issue: fedora-modularity#192
athira-selvam added a commit to athira-selvam/libmodulemd that referenced this issue Mar 14, 2019
@athira-selvam
Extends tests for ModuleStream.depends_on_stream()
91b17b6 
The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists

Fixes:fedora-modularity#192
athira-selvam added a commit to athira-selvam/libmodulemd that referenced this issue Mar 15, 2019
@athira-selvam
Extends tests for ModuleStream.depends_on_stream()
ab38c67 
The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists

Fixes:fedora-modularity#192
athira-selvam added a commit to athira-selvam/libmodulemd that referenced this issue Mar 15, 2019
@athira-selvam
Extends tests for ModuleStream.depends_on_stream()
f69fa45 
The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists

Fixes:fedora-modularity#192
athira-selvam added a commit to athira-selvam/libmodulemd that referenced this issue Mar 15, 2019
@athira-selvam
Extends tests for ModuleStream.depends_on_stream()
ee0ee95 
[updated]The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists

Fixes:fedora-modularity#192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Easy tickets suitable for a new contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgallagher @athira-selvam