Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance IndexMerger to use equality checks #188

Closed
sgallagher opened this issue Feb 14, 2019 · 7 comments · Fixed by #304
Closed

Enhance IndexMerger to use equality checks #188

sgallagher opened this issue Feb 14, 2019 · 7 comments · Fixed by #304
Labels
good first issue Easy tickets suitable for a new contributor

Comments

@sgallagher
Copy link
Collaborator

Right now, we use a highly-simplified comparison when merging ModuleStream objects from two different repositories. We check whether they have the same NSVC and then assume them to be the same content. It would be better to perform a full equality check.

This depends on #186
@sgallagher sgallagher added the good first issue Easy tickets suitable for a new contributor label Feb 14, 2019
@irenge
Copy link

irenge commented Feb 22, 2019

Hi
May I work on this issue ?
Thanks

@sgallagher
Copy link
Collaborator Author

@irenge Please go ahead.

@athira-selvam
Copy link
Contributor

Hi @irenge are you working on this issue?

@irenge
Copy link

irenge commented Mar 16, 2019

haha ! I thought the issue was closed . I am going back to it . R u interested in it ?

@sgallagher
Copy link
Collaborator Author

This isn't eligible to be worked on until #186 is merged. That issue needs to be resolved first.

@athira-selvam
Copy link
Contributor

@sgallagher Hi, All beginner issues have been claimed. Is it okay to work on those issues? I have already copied tests for the depends_on_stream function to C. And I added a test for an empty stream. But that was in python. Can I work on copying that test to C and also copying some more functions from modulestream.py to C?
Can I work on - 199or 198
Or can you assign me something else to work on

@sgallagher
Copy link
Collaborator Author

@athira-selvam If there isn't a specific issue available (and I don't have a spare moment today to try to come up with some new ones), my recommendation would be to look through the existing tests in the v2 subdirectory, look at some edge-cases that aren't exercised there and submit some new tests.

@sgallagher sgallagher mentioned this issue May 22, 2019
Merged
sgallagher added a commit to sgallagher/libmodulemd that referenced this issue May 22, 2019
@sgallagher
Check full stream equality when deduplicating
10e0db0 
Previously, we assumed that any two streams having the same NSVCA
were identical. Now we can actually test for full equality before
dropping one while deduplicating. Note that this will result in a
hard failure if they aren't identical, because this means that the
enabled repositories are providing conflicting data.

Fixes: fedora-modularity#188

Signed-off-by: Stephen Gallagher <[email protected]>
@sgallagher sgallagher mentioned this issue May 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Easy tickets suitable for a new contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check full stream equality when deduplicating sgallagher/libmodulemd
3 participants
@sgallagher @irenge @athira-selvam