Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to the new SQLAlchemy 2.0 API #54

Open
abompard opened this issue Apr 11, 2024 · 1 comment
Open

Migrate to the new SQLAlchemy 2.0 API #54

abompard opened this issue Apr 11, 2024 · 1 comment
Labels
enhancement

Comments

@abompard
Copy link
Member

There's a new API style in SQLAlchemy 2.0: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html
@abompard abompard added enhancement good first issue Good for new contributors labels Apr 11, 2024
@abompard
Copy link
Member Author

Be careful, there are many places in Tahrir that get a Query from tahrir_api and then build upon it by adding .filter() and .order_by() calls. This will not be possible with the SQLAlchemy 2.0 API.

@abompard abompard removed the good first issue Good for new contributors label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abompard