Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

The SCM module doesn't handle network outages gracefully #432

Open
jeremycline opened this issue Jul 7, 2017 · 0 comments
Open

The SCM module doesn't handle network outages gracefully #432

jeremycline opened this issue Jul 7, 2017 · 0 comments

Comments

@jeremycline
Copy link
Member

The SCM module doesn't handle network outages gracefully, nor does it document that it might raise a requests exception:

content = fedmsg.meta.msg2long_form(msg, **self.config) or u''
File "/usr/lib/python2.7/site-packages/fedmsg/meta/__init__.py", line 142, in __wrapper
return f(msg, **config)
File "/usr/lib/python2.7/site-packages/fedmsg/meta/__init__.py", line 161, in __wrapper
return f(msg, processor=processor, **config)
File "/usr/lib/python2.7/site-packages/fedmsg/meta/__init__.py", line 247, in msg2long_form
result = processor.long_form(msg, **config)
File "/usr/lib/python2.7/site-packages/fedmsg_meta_fedora_infrastructure/scm.py", line 67, in long_form
response = requests.get(url.format(repo=repo, rev=rev))
File "/usr/lib/python2.7/site-packages/requests/api.py", line 68, in get
return request('get', url, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/api.py", line 50, in request
response = session.request(method=method, url=url, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 464, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 602, in send
history = [resp for resp in gen] if allow_redirects else []
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 195, in resolve_redirects
allow_redirects=False,
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 576, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 415, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', error(110, 'Connection timed out'))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant