Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Bitcoin RPC connection validation in Admin Guardian Setup #538

Open
hensg opened this issue Sep 24, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@hensg
Copy link
Contributor

hensg commented Sep 24, 2024

Add a test connection validation for the Bitcoin RPC during the Admin Guardian Setup [1], similar to the functionality provided by Sparrow [2]. This feature would ensure that the Bitcoin RPC is configured correctly, preventing common mistakes like incorrect RPC addresses or missing passwords.

Without this validation, users might accidentally generate an invalid bitcoin RPC address in local.json, causing the Fedimint service to fail to start. The user would then need to manually edit the local.json to fix the issue, which could be error-prone and time-consuming.

  1. Admin Guardian Setup
    image

  2. Sparrow Bitcoin RPC configuration
    image

@hensg hensg added the enhancement New feature or request label Sep 24, 2024
@hensg hensg assigned Kodylow and unassigned Kodylow Sep 24, 2024
@Kodylow
Copy link
Member

Kodylow commented Sep 24, 2024

We talked about this previously and this needs to be implemented fedimint side not ui side, but agree we need it @dpc

@Kodylow
Copy link
Member

Kodylow commented Sep 24, 2024

I also can't do this in the browser because of CORs, so has to be backend

@elsirion
Copy link
Contributor

fedimint/fedimint#5968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants