-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying protocol version in request specs #65
Comments
Can I take this? |
Yes! Do you have an initial idea of how you would like to implement it? |
Hey, sorry for not getting back. I have been working on this and will hopefully be done within the next week. I have tried to implement protocol the same way method is implemented. I have added a defconst for valid protocols, a verb--http-protocol-type, a verb--http-protocol-p and a verb--http-protocols-regexp. I have also added protocol to the request spec. I am now working on turning the method+url section into method+url+protocol, so that users could make requests just as you suggested: get http://example.com http/1.1. |
No worries! |
Have you gotten a chance to look at my PR yet? |
Users could optionally specify HTTP protocol versions. Instead of
one could write:
(upper case would be parsed correctly as well)
Adding the protocol version would be of course optional and 1.1 would be assumed if omitted. All this could be useful in the future if
url.el
is updated to support HTTP 2.0 or 3.0.The text was updated successfully, but these errors were encountered: