Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying protocol version in request specs #65

Open
federicotdn opened this issue Apr 14, 2024 · 5 comments
Open

Allow specifying protocol version in request specs #65

federicotdn opened this issue Apr 14, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@federicotdn
Copy link
Owner

Users could optionally specify HTTP protocol versions. Instead of

get http://example/com

one could write:

get http://example.com http/1.1

(upper case would be parsed correctly as well)
Adding the protocol version would be of course optional and 1.1 would be assumed if omitted. All this could be useful in the future if url.el is updated to support HTTP 2.0 or 3.0.

@federicotdn federicotdn added enhancement New feature or request good first issue Good for newcomers labels Apr 14, 2024
@federicotdn federicotdn changed the title Allow specifying procol version in request specs Allow specifying protocol version in request specs Jun 19, 2024
@vHugoObject
Copy link

Can I take this?

@federicotdn
Copy link
Owner Author

Yes! Do you have an initial idea of how you would like to implement it?

@vHugoObject
Copy link

Hey, sorry for not getting back. I have been working on this and will hopefully be done within the next week. I have tried to implement protocol the same way method is implemented. I have added a defconst for valid protocols, a verb--http-protocol-type, a verb--http-protocol-p and a verb--http-protocols-regexp. I have also added protocol to the request spec. I am now working on turning the method+url section into method+url+protocol, so that users could make requests just as you suggested: get http://example.com http/1.1.

@federicotdn
Copy link
Owner Author

No worries!
That sounds good; feel free to open a PR anytime.

@vHugoObject
Copy link

Have you gotten a chance to look at my PR yet?

@federicotdn federicotdn removed the good first issue Good for newcomers label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants