Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a Form 3x monthly report March 20 the covering period is incorrect #2565

Closed
exalate-issue-sync bot opened this issue Feb 27, 2025 · 4 comments
Assignees
Labels
defect Something isn't working

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Feb 27, 2025

Where was the issue found:

  • Committee ID: C00100495 Environment: DEV/STAGE

Please describe the issue: When selecting a Form 3x Monthly Report for March 20 (M3) the covering period should be From 02/01/2025 To 02/28/2025.

Approximate time the issue was found: 9:15 am 02/27/2025

Steps to Reproduce:

  1. Select create a Form 3x report
  2. Select Monthly Reporting
  3. Select March 20 Monthly Report (M3)
  4. Covering period is displaying From 02/01/2025 To 03/01/2025 (This is the defect)
  5. Covering period should be From 02/01/2025 To 02/28/2025

image-20250227-174437.png

Mitchell Jarrett Todd Lees per direction defect pointed 2 points and assigned to Sprint 57.

QA Notes

None

DEV Notes

This should also be 02/29/xxxx on years with 29 days in february.
[https://github.com/fecgov/fecfile-web-app/blob/b0fd63b4f3ce88fcb5ab10e1dabd6ed4480333da/front-end/src/app/shared/utils/report-code.utils.ts#L52|https://github.com/fecgov/fecfile-web-app/blob/b0fd63b4f3ce88fcb5ab10e1dabd6ed4480333da/front-end/src/app/shared/utils/report-code.utils.ts#L52|smart-link]

we’ll need to update the 29 to be 29 on those years and 28 on years where there are 28 days

Design

None

See full ticket and images here: FECFILE-2062

Pull Request: #2568

@exalate-issue-sync exalate-issue-sync bot added the defect Something isn't working label Feb 27, 2025
Copy link
Author

Todd Lees commented: See updated dev notes with handling years with 29 days

Copy link
Author

Todd Lees commented: complete

Copy link
Author

Shelly Wise commented: QA review verified defect fix.

Selected create a Form 3x report

Selected Monthly Reporting

Selected March 20 Monthly Report (M3)

Covering period displayed correctly From 02/01/2025 To 02/28/2025

!image-20250304-165653.png|width=835,height=694,alt="image-20250304-165653.png"!

QA Review Completed. Moved to Stage Ready.

Copy link
Author

Automation for Jira commented: Sprint accepted by Paul Clark during Sprint Review on the date of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant