[User feedback] Aggregate calculation (for Schedule A) not working as expected

[exalate-issue-sync]

User feedback:

”I entered a 2nd contribution from a donor I had already created, and the aggregate total didn’t update until I saved the transaction. It would be super helpful if that field would recalculate before the save, so that I could see if that contribution would cause a donation to be over the limit.”

”I had a $10 (individual?) receipt on 1/2/25, and then I added a $500 for the same date, just because I was curious about that field. I already deleted that since I was just playing around, and my goal for now is to try and re-create this monthly report so I can get a feel for it and have something verifiable to check it against.”

QA Notes

null

DEV Notes

Design

See full ticket and images here: FECFILE-2044

Pull Request: #2570

[WiseQA]

QA looked at this ticket, seems to be a design question on how this works.

[exalate-issue-sync]

Shelly Wise commented: QA will retest this ticket with information reported. I initially thought this was a design issue, but will run through this scenario reported.

[exalate-issue-sync]

Shelly Wise commented: Verified this is a bug with [~accountid:61b0b42cc510bc006b5c03ed] - the aggregate box is not calculating on the fly like it has been. Aggregate should update when entering a transaction, before you save. (This is the bug)

Aggregate total updates when saving the transaction not on the fly when entering aggregate in the transaction.

[~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] please add the DEV notes what code the system is supposed to be looking for to make the aggregate box work correctly.

[~accountid:61b0b42cc510bc006b5c03ed] [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] Bug found and reported from User Feedback. Tested on STAGE after sprint 56 pushed. Per conversation pointed 3 points and assigned to Sprint 57.

[exalate-issue-sync]

Elaine Krauss commented: I’ve got a tentative fix. The fix works, but it seems more complicated than necessary. It needs unit tests and a new E2E regression test, and I also want to review it at the next weekly dev meeting.

[exalate-issue-sync]

Todd Lees commented: Aggregate calculation on form now refreshes correctly.
With an existing transaction for contact 1 on march 6, for $1

!image-20250306-032024.png|width=1686,height=182,alt="image-20250306-032024.png"!

creating a new transaction for contact 1 on march 7 for $2 results in $3 aggregate

!image-20250306-032127.png|width=1658,height=766,alt="image-20250306-032127.png"!

changing contact to contact 2

!image-20250306-032159.png|width=1166,height=430,alt="image-20250306-032159.png"!

results in the aggregate of $2 because there are no previous transactions for contact 2

!image-20250306-032249.png|width=1628,height=670,alt="image-20250306-032249.png"!

[exalate-issue-sync]

Shelly Wise commented: [~accountid:61b0b42cc510bc006b5c03ed] [~accountid:712020:eaccd25d-427c-4e4d-a650-909ec0b31071] [~accountid:712020:2a1493e5-adee-45bd-b27e-868a5c8d3f62] aggregate is not calculating correctly.

!. Created Individual Receipt - Created New Contact. Entered $29.99 first transaction. 2nd Individual Receipt transaction created using the same contact for $300.00.

!image-20250306-213224.png|width=1383,height=129,alt="image-20250306-213224.png"!

When opening the first transaction created - aggregate should display as $329.99, however displaying as $359.98. (This is the bug adding $29.99 again when editing first transaction)

!image-20250306-213328.png|width=1335,height=161,alt="image-20250306-213328.png"!

Sending ticket back to in-progress per conversation for this fix.

[exalate-issue-sync]

Elaine Krauss commented: In response to the bug that [~accountid:712020:169a1b29-e3ab-43ca-a22d-7d6f230207bd] found, I’ve created a PR that resolves the issue [here|https://github.com/fecgov/fecfile-web-api/pull/1378].

There is an additional front-end bug that still needs to be addressed.

[exalate-issue-sync]

Todd Lees commented: Issues from testing addressed in [https://github.com//pull/2591|https://github.com//pull/2591|smart-link] [https://github.com//pull/2593|https://github.com//pull/2593|smart-link] [https://github.com/fecgov/fecfile-web-api/pull/1378|https://github.com/fecgov/fecfile-web-api/pull/1378|smart-link] [https://github.com/fecgov/fecfile-web-api/pull/1379|https://github.com/fecgov/fecfile-web-api/pull/1379|smart-link]

[exalate-issue-sync]

Shelly Wise commented: QA review verified bug fixed for this defect found during testing.

Created Individual Receipt - Created New Contact. Entered $39.99 first transaction. 2nd Individual Receipt transaction created using the same contact for $300.00.

!image-20250307-174050.png|width=1171,height=133,alt="image-20250307-174050.png"!

When opening the first transaction created - aggregate displayed as $39.99, (This is correct)

!image-20250307-174725.png|width=912,height=365,alt="image-20250307-174725.png"!

When opening the second transaction created - aggregate displayed is $339.99. (This is correct)

!image-20250307-174646.png|width=1079,height=348,alt="image-20250307-174646.png"!

Per review with DEV this defect passes.

QA Review Completed. Moved to Stage Ready.

[exalate-issue-sync]

Automation for Jira commented: Sprint accepted by Paul Clark during Sprint Review on the date of this comment.