Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Linear Regression Assumptions #581

Open
NicoGalli opened this issue Jan 3, 2023 · 4 comments
Open

Testing Linear Regression Assumptions #581

NicoGalli opened this issue Jan 3, 2023 · 4 comments

Comments

@NicoGalli
Copy link
Collaborator

Checking model assumptions is like commenting code. Everybody should be doing it often, but it sometimes ends up being overlooked in reality. A failure to do either can result in a lot of time being confused, going down rabbit holes, and can have pretty serious consequences from the model not being interpreted correctly.

What about creating the following functions to test linear regression assumptions?

linear_assumption()
normal_errors_assumption()
multicollinearity_assumption()
autocorrelation_assumption()
homoscedasticity_assumption()

Please check this amazing post: https://jeffmacaluso.github.io/post/LinearRegressionAssumptions/

@Morgan-Sell
Copy link
Collaborator

Nice idea, @NicoGalli!

Has anyone started this task? If not, I'll take it on.

@NicoGalli
Copy link
Collaborator Author

Hi @Morgan-Sell!

Yes, please. Dont hesitate to assign this task to you and start working on it.

@Morgan-Sell
Copy link
Collaborator

Hi @NicoGalli,

I understand the request. However, I'm questioning whether this task should be within the scope of feature-engine. feature-engine focuses on automating feature engineering/selection that is compatible with scikit-learn.

Assessing linear regression assumptions falls under model evaluation, which I believe to beyond the scope of feature-engine.

@solegalli, do you have any thoughts?

@solegalli
Copy link
Collaborator

Yes, I think that for the time being, this will be out of scope. There are other issues with higher priority.

Maybe in a few years :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants