From 9c9079092a8bd43fae023db14a67304d3f3f536b Mon Sep 17 00:00:00 2001 From: Francisco Javier Arceo Date: Tue, 24 Sep 2024 23:32:55 -0400 Subject: [PATCH] updated tests to test actual behavior Signed-off-by: Francisco Javier Arceo --- .../tests/unit/test_on_demand_python_transformation.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sdk/python/tests/unit/test_on_demand_python_transformation.py b/sdk/python/tests/unit/test_on_demand_python_transformation.py index cf92b6dbcb..0e7e254587 100644 --- a/sdk/python/tests/unit/test_on_demand_python_transformation.py +++ b/sdk/python/tests/unit/test_on_demand_python_transformation.py @@ -562,7 +562,7 @@ def setUp(self): source=driver_stats_source, ) assert driver_stats_fv.entities == [driver.name] - assert driver_stats_fv.entity_columns == [driver.name] + assert driver_stats_fv.entity_columns == [] @on_demand_feature_view( entities=[driver], @@ -604,9 +604,10 @@ def python_stored_writes_feature_view( python_stored_writes_feature_view, ] ) - applied_fv = self.store.get_feature_view("driver_hourly_stats") - assert applied_fv.entities[0] == driver.name - assert applied_fv.entity_columns[0].name == driver.name + fv_applied = self.store.get_feature_view("driver_hourly_stats") + assert fv_applied.entities == [driver.name] + # Note here that after apply() is called, the entity_columns are populated with the join_key + assert fv_applied.entity_columns[0].name == driver.join_key self.store.write_to_online_store( feature_view_name="driver_hourly_stats", df=driver_df