Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependencies prevent module from properly installing alongside React 18 #181

Open
sitarharel opened this issue Dec 9, 2022 · 2 comments

Comments

@sitarharel
Copy link

Module was fixed to work with react 18 here: #172

However, package.json was not updated to allow for react ^18.0.0 as a peer dependency and thus the following error appears on npm install:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.3 || ^17.0.0" from [email protected]
npm ERR! node_modules/react-video-recorder
npm ERR!   react-video-recorder@"^3.19.4" from the root project
npm ERR!
@davidcedres
Copy link

👀

@domschab23
Copy link

@fbaiodias it'd be extremely helpful if we could update peer deps (unless there's something else not working alongside react 18)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@sitarharel @davidcedres @domschab23 and others