Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator does not allow null present_value #383

Open
DollyGodet opened this issue Jun 30, 2022 · 2 comments
Open

Validator does not allow null present_value #383

DollyGodet opened this issue Jun 30, 2022 · 2 comments

Comments

@DollyGodet
Copy link

Here is the pointset_event I am trying to validate with the validator :

  
{
  "timestamp": "2022-06-30T13:48:13.375Z",
  "version": "1.3.13",
  "points": {
    "schedule1": {
      "present_value": null
    },
    "binary_value1": {
      "present_value": "Active"
    },
    "analog_value1": {
      "present_value": 6.0
    },
    "multi_state_value1": {
      "present_value": 1
    }
  }
}
  

It looks like the validator does not accept null present_value.
Here is the content of the event_pointset.out file :

  
While converting to json node: 1 schema violations found
  1 schema violations found
    object has missing required properties (["present_value"])
  

I think the validator should accept a null present_value, because some BACnet object can have a null present_value (and it is valid).
For exemple, a schedule object can have a null present_value.
The present_value field is required, but the ObjectMapper of the validator considers a null value as a missing property.

@noursaidi
Copy link
Collaborator

I agree with you, I think null should be acceptable value. Tagging @grafnu

@grafnu
Copy link
Collaborator

grafnu commented Jul 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants