New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect authentication results ptype #10

Open

kitterma opened this issue Feb 28, 2018 · 1 comment

Assignees

kitterma commented Feb 28, 2018

See line 55 of https://github.com/fastmail/authentication_milter/blob/master/lib/Mail/Milter/Authentication/Handler/TLS.pm. x-tls is not correct. The correct pytpe for a TLS result would be smtp because it is information acquired during the smtp session. TLS usages should also be registered as a new smtp property, but that's a separate issue.

marcbradshaw self-assigned this

Member

marcbradshaw commented Mar 14, 2018

Thanks, I suspect there are a few more of these in other Handlers too. I'll make a note to check through and fix them up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment