Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stats alerts, add all service aggregate alerts #831

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jsonroy-fastly
Copy link
Contributor

The purpose of this PR is to fix and add a functionality to alerts.

  • Provide a bugfix for any alerts that has stats as a source which was failing on the dimensions field.
  • Adding a new all service aggregate alerts feature.

Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll run the tests locally tomorrow and will merge if all is well.

@Integralist
Copy link
Collaborator

Ran complete test suite and all ✅

@Integralist Integralist merged commit 18d5ce6 into fastly:main Apr 16, 2024
9 checks passed
@jsonroy-fastly jsonroy-fastly deleted the account-aggregate branch April 16, 2024 12:43
@jsonroy-fastly jsonroy-fastly restored the account-aggregate branch May 24, 2024 12:43
@jsonroy-fastly jsonroy-fastly deleted the account-aggregate branch May 24, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants