Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry ignores limit response headers when hourly API rate limit is reached #313

Open
matejlukac opened this issue Sep 16, 2020 · 0 comments
Labels

Comments

@matejlukac
Copy link

Terraform fastly provider is not utilizing fastly limitation response headers when executing non-read requests.
https://developer.fastly.com/reference/api/#rate-limiting.

Rate limit information is provided in response headers, as shown below. The Fastly-RateLimit-Remaining header provides the number of API requests remaining in the current rate limit window. The Fastly-RateLimit-Reset provides the time at which the current rate limit window resets, as a Unix timestamp.

Fastly-RateLimit-Remaining: 999
Fastly-RateLimit-Reset: 1452032384

Terraform Version

v0.12.17

Expected Behavior

Terraform should retry non-read requests after the time specified in fastly response header when API rate limit is reached.

Actual Behavior

Error is thrown after API rate limit is reached.
Error: 429 - Too Many Requests:
Title: You have exceeded your hourly rate limit. Please contact [email protected] if you think this is a mistake.

Steps to Reproduce

Execute the number of non-read requests larger than hourly rate limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants