Skip to content

Commit b1462ec

Browse files
author
Jake Champion
committed
remove the else branches that zero the memory of definition as it's being memset at the function entry
1 parent 028cf02 commit b1462ec

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

c-dependencies/js-compute-runtime/builtins/backend.cpp

-15
Original file line numberDiff line numberDiff line change
@@ -336,41 +336,26 @@ JS::Result<mozilla::Ok> Backend::register_dynamic_backend(JSContext *cx, JS::Han
336336
backend_config_mask |= BACKEND_CONFIG_HOST_OVERRIDE;
337337
definition.host_override = hostOverride.value().c_str();
338338
definition.host_override_len = hostOverride.value().length();
339-
} else {
340-
definition.host_override = nullptr;
341-
definition.host_override_len = 0;
342339
}
343340
if (certificateHostname.has_value()) {
344341
backend_config_mask |= BACKEND_CONFIG_CERT_HOSTNAME;
345342
definition.cert_hostname = certificateHostname.value().c_str();
346343
definition.cert_hostname_len = certificateHostname.value().length();
347-
} else {
348-
definition.cert_hostname = nullptr;
349-
definition.cert_hostname_len = 0;
350344
}
351345
if (caCertificate.has_value()) {
352346
backend_config_mask |= BACKEND_CONFIG_CA_CERT;
353347
definition.ca_cert = caCertificate.value().c_str();
354348
definition.ca_cert_len = caCertificate.value().length();
355-
} else {
356-
definition.ca_cert = nullptr;
357-
definition.ca_cert_len = 0;
358349
}
359350
if (ciphers.has_value()) {
360351
backend_config_mask |= BACKEND_CONFIG_CIPHERS;
361352
definition.ciphers = ciphers.value().c_str();
362353
definition.ciphers_len = ciphers.value().length();
363-
} else {
364-
definition.ciphers = nullptr;
365-
definition.ciphers_len = 0;
366354
}
367355
if (sniHostname.has_value()) {
368356
backend_config_mask |= BACKEND_CONFIG_SNI_HOSTNAME;
369357
definition.sni_hostname = sniHostname.value().c_str();
370358
definition.sni_hostname_len = sniHostname.value().length();
371-
} else {
372-
definition.sni_hostname = nullptr;
373-
definition.sni_hostname_len = 0;
374359
}
375360

376361
int result = xqd_req_register_dynamic_backend(name_cstr, name_len, target_cstr, target_len,

0 commit comments

Comments
 (0)