Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add origin_fetch_resp_*_bytes in Stats struct #548

Open
kartheekkaipa opened this issue Sep 30, 2024 · 3 comments
Open

add origin_fetch_resp_*_bytes in Stats struct #548

kartheekkaipa opened this issue Sep 30, 2024 · 3 comments

Comments

@kartheekkaipa
Copy link

Currently go-fastly do not have field for bytes fetched from origin for Stats response for GetStatsField function.

  • origin_fetch_resp_body_bytes
  • origin_fetch_resp_header_bytes

File: fastly/stats_historical.go

if it's okay, I will raise the PR for the change.

@kpfleming
Copy link
Contributor

Indeed, those are documented here and here. A PR would be very welcome!

@kartheekkaipa
Copy link
Author

I will start with changes.

I am getting 404 for the above links, can you please check the same.

Thank you

@kpfleming
Copy link
Contributor

Oh, sorry, those were internal links, my apologies!

The public documentation for those fields is here.

Take a look at the CONTRIBUTING and TESTING files to understand what you'll need to do to enhance the existing test fixtures to support those new fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants