Resolve undefined url middleware #648
Conversation
bump dependencies too #612
index.js
Outdated
| const app = Next(Object.assign({}, { dev: process.env.NODE_ENV !== 'production' }, nextOptions)) | ||
| const app = Next(Object.assign({}, { | ||
| dev: process.env.NODE_ENV !== 'production', | ||
| hostname: hostname !== undefined ? hostname : '0.0.0.0', |
There was a problem hiding this comment.
I don't understand. Why you need to pass hostname and port to Next?
There was a problem hiding this comment.
Really not a good idea to use 0.0.0.0 by default.
There was a problem hiding this comment.
Hey, because for obscure reason Next.js need pass port and hostname for prevent the undefined result
According to the docs :
// when using middleware `hostname` and `port` must be provided below
const app = next({ dev, hostname, port })https://nextjs.org/docs/advanced-features/custom-server
this problem exist too with firebase (without fastfy server ) : vercel/next.js#41210
There was a problem hiding this comment.
Really not a good idea to use
0.0.0.0by default.
i can replace by localhost if you want
|
Is there anything blocking the merge of this PR? |
| if (underPressure) { | ||
| const opts = typeof underPressure === 'object' ? underPressure : Object.create(null) | ||
|
|
||
| fastify.register(require('@fastify/under-pressure'), opts) | ||
| } | ||
|
|
||
| const app = Next(Object.assign({}, { dev: process.env.NODE_ENV !== 'production' }, nextOptions)) | ||
| const app = Next(Object.assign({}, { |
There was a problem hiding this comment.
After some though, the developer can pass hostname and port directly to the options.
So, when we are helping them to do it. It means that they will never know it is a requirement.
Does middle-ware work when they pass the option through ?
fastify.register(fastifyNext, {
hostname: 'localhost',
port: 3000
})If yes, I am pretty much against this PR.
Can you try if this works? fastify.register(fastifyNext, {
hostname: 'localhost',
port: 3000
}) |
It works. We can just update the docs |
Resolve #612
Force to assign Host and Port to Next Server for prevent undefined URL when middleware is enabled
Checklist
npm run testandnpm run benchmarkand the Code of conduct