Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible thumbnails after window resizing #326

Open
e1a6 opened this issue May 8, 2024 · 4 comments
Open

Invisible thumbnails after window resizing #326

e1a6 opened this issue May 8, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@e1a6
Copy link

e1a6 commented May 8, 2024

Hello,

First, thank you for sharing your work. You really made a useful app.

I use very small dials (favicon size) and when I reduce the size of the browser window, they become so small that they disappear, which makes them unusable.

So I was wondering if there was a way to block the size of the thumbnail so that it doesn't change size whenever the window is resized in order to have a fixed layout with fixed thumbnails size at all time.

@e1a6 e1a6 added the enhancement New feature or request label May 8, 2024
@Juraj-Masiar
Copy link
Member

Hello,
You can change the layout of the group to a different one, that uses fixed sized dials - right click group name or open main menu and select Edit group.

I plan to add a new layout soon that will show only favicons and text below (like desktop icons). So that would be helpful for this case for sure.

@e1a6
Copy link
Author

e1a6 commented May 13, 2024

Thank you for your quick response and help. I tried using the layout with fixed size dials, but it's a dynamic layout which doesn't suit the way I set my dials. (I like to have them grouped in different columns with different numbers of dials, and the constraint of dynamic dial doesn't allow for that compared to a traditional grid). The ideal would be a grid with a fixed sized dial that doesn't change size when the browser's window is resized.

I'm glad to hear that you plan to make a new layout with favicons, it sure would help, but from what I understand there are limitations regarding favicons on Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1315616).

For my use case, if possible, just allowing the layout that uses fixed dials to have a grid instead of being dynamic would be plenty enough.

Anyway, thanks again for being so reachable and willing to help.

@Juraj-Masiar
Copy link
Member

Oh, I see, the center/scroll dials layout are using fixed aspect ratio, not the size.
So, this is a bit complicated. If you want to have fixed dial size with a fixed layout, than what should happen when you resize window so they don't fit inside the screen?
I did solve this in Android by adding a min-width option, but it's disabled on desktop. Maybe I should enable it. It will then cause a big horizontal/vertical scrollbar on the page when the page is too small.

Regarding the favicons issue you've linked, that's not a problem, my addon is downloading all favicons directly from pages (for example: https://github.com/favicon.ico). Plus I have a huge icons library on my server.

@e1a6
Copy link
Author

e1a6 commented May 14, 2024

If you want to have fixed dial size with a fixed layout, than what should happen when you resize window so they don't fit inside the screen?

Before looking for a dial add-on, I used to use the native bookmark toolbar of the browser that gives you easy access to website shortcuts, but I didn't like the fact that the shortcuts were so spread horizontally so the idea was to center them in order to not have to move the mouse from edge to edge of the screen.

Favicons are so small that it allows to resize the browser window to a quarter of it's size while still being visible and usable but when the size of the thumbnail is related to the size of the window and the browser's window reaches a quarter of it's size, the thumbnails then basically become a dot on the screen (not visible nor usable).

I don't mind the large scroll bars personally, so if an option with a toggle was available in the add-on to enable a fixed sized dial with fixed layout for those who need it like me, i would be all for it.

I'm glad to hear that the favicon issue is not a problem for you. Your app is the most polished and feature full I've seen, I'm not surprised you found a work around an issue that many other devs are facing. Kudos to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants